From: Roland Hieber <rhi@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v1 3/3] amba: pl011: make locally used functions static
Date: Thu, 14 Feb 2019 14:51:57 +0100 [thread overview]
Message-ID: <20190214135157.sy2l2x6re3xspohu@pengutronix.de> (raw)
In-Reply-To: <20190115103423.5233-3-rhi@pengutronix.de>
Hi Sascha,
the other two patches in this series are on master now, but this one
seems to have fallen through the cracks.
- Roland
On Tue, Jan 15, 2019 at 11:34:23AM +0100, Roland Hieber wrote:
> This function is not part of a public interface and only used locally.
>
> Fixes the following build warning:
>
> .../drivers/serial/amba-pl011.c:151:5: warning: no previous prototype for 'pl011_init_port' [-Wmissing-prototypes]
> int pl011_init_port (struct console_device *cdev)
> ^~~~~~~~~~~~~~~
>
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
> drivers/serial/amba-pl011.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/serial/amba-pl011.c b/drivers/serial/amba-pl011.c
> index 4c4067d5b5..99b82e3c03 100644
> --- a/drivers/serial/amba-pl011.c
> +++ b/drivers/serial/amba-pl011.c
> @@ -148,7 +148,7 @@ static void pl011_rlcr(struct amba_uart_port *uart, u32 lcr)
> }
> }
>
> -int pl011_init_port (struct console_device *cdev)
> +static int pl011_init_port(struct console_device *cdev)
> {
> struct amba_uart_port *uart = to_amba_uart_port(cdev);
>
> --
> 2.20.1
>
>
--
Roland Hieber | r.hieber@pengutronix.de |
Pengutronix e.K. | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-02-14 13:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 10:34 [PATCH v1 1/3] ARM: rpi: " Roland Hieber
2019-01-15 10:34 ` [PATCH v1 2/3] mci: bcm2835: " Roland Hieber
2019-01-15 10:34 ` [PATCH v1 3/3] amba: pl011: " Roland Hieber
2019-02-14 13:51 ` Roland Hieber [this message]
2019-02-18 8:52 ` Sascha Hauer
2019-02-22 9:23 ` Roland Hieber
2019-01-16 7:52 ` [PATCH v1 1/3] ARM: rpi: " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214135157.sy2l2x6re3xspohu@pengutronix.de \
--to=rhi@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox