From: Tomaz Solc <tomaz.solc@tablix.org>
To: barebox@lists.infradead.org
Subject: [PATCH v2 5/8] mci: bcm2835: use device_initcall(), not coredev.
Date: Mon, 18 Feb 2019 12:32:17 +0100 [thread overview]
Message-ID: <20190218113220.18649-6-tomaz.solc@tablix.org> (raw)
In-Reply-To: <20190218113220.18649-1-tomaz.solc@tablix.org>
pinctrl driver needs to be initialized before mci driver on Raspberry Pi.
Otherwise the pinctrl device tree properties in the mci node are ignored.
pinctrl is initialized by coredevice_initcall(), so moving mci-bcm2835 to
device_initcall() ensures that it is initialized later.
There is no reason for mci-bcm2835 to use coredevice_initcall(). Other mci
drivers already use device_initcall().
---
drivers/mci/mci-bcm2835.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mci/mci-bcm2835.c b/drivers/mci/mci-bcm2835.c
index 9438e66af..e7dbb4f1d 100644
--- a/drivers/mci/mci-bcm2835.c
+++ b/drivers/mci/mci-bcm2835.c
@@ -561,4 +561,4 @@ static int bcm2835_mci_add(void)
{
return platform_driver_register(&bcm2835_mci_driver);
}
-coredevice_initcall(bcm2835_mci_add);
+device_initcall(bcm2835_mci_add);
--
2.11.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-02-18 11:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 11:32 [PATCH v2 0/8] Fixing MMC access on Raspberry Pi CM3 Tomaz Solc
2019-02-18 11:32 ` [PATCH v2 1/8] ARM: rpi: switch emmc from sdhost to sdhci Tomaz Solc
2019-02-18 11:32 ` [PATCH v2 2/8] Kconfig: add pin controllers submenu Tomaz Solc
2019-02-18 11:32 ` [PATCH v2 3/8] pinctrl: bcm2835: move existing code from gpio Tomaz Solc
2019-02-18 11:32 ` [PATCH v2 4/8] pinctrl: bcm2835: register the pin controller Tomaz Solc
2019-02-18 11:32 ` Tomaz Solc [this message]
2019-02-18 11:32 ` [PATCH v2 6/8] mci: bcm2835: parse other device tree properties Tomaz Solc
2019-02-18 11:32 ` [PATCH v2 7/8] ARM: rpi: Add device tree for Compute Module 3 Tomaz Solc
2019-02-18 11:32 ` [PATCH v2 8/8] ARM: rpi: add CONFIG_PINCTRL to rpi_defconfig Tomaz Solc
2019-02-19 9:08 ` [PATCH v2 0/8] Fixing MMC access on Raspberry Pi CM3 Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218113220.18649-6-tomaz.solc@tablix.org \
--to=tomaz.solc@tablix.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox