From: Sam Ravnborg <sam@ravnborg.org>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/4] ARM: at91: debug_ll: make UART base address configurable
Date: Tue, 19 Feb 2019 21:42:33 +0100 [thread overview]
Message-ID: <20190219204233.GA14204@ravnborg.org> (raw)
In-Reply-To: <20190219120612.728-3-a.fatoum@pengutronix.de>
Hi Ahmad.
On Tue, Feb 19, 2019 at 01:06:10PM +0100, Ahmad Fatoum wrote:
> This is in line with other platforms such as i.MX, which allow
> specifying a debug port. As we can't use port indices because
> the UARTs aren't mapped consecutively, allow specifying a hex
> base at configuration time.
>
> A side effect of this patch is that sama5d4's HAVE_AT91_DBGU2
> is now honored as well. Previously anything besides DBGU0
> defaulted to DBGU1.
This approch hardcoded the DBGU address based on the configuration.
Can you somehow come up with something that is run-time configured?
So we can continue towards the goal to have multi-image support
for at91.
The current approch will limit us to a single type of SOC -
and we may try to combine more than one SOC in the same multi-iamge
sometime in the future.
Maybe each board have to call an debug_ll_init(address) function or similar.
If not called we can use the default which is the common address
for most at91 SOCs.
Or maybe something smarter.
Sam
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-02-19 20:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 12:06 [PATCH 0/4] ARM: at91: misc fixes and cleanup Ahmad Fatoum
2019-02-19 12:06 ` [PATCH 1/4] ARM: at91: replace __raw_{readl, writel} of peripherals with readl, writel Ahmad Fatoum
2019-02-19 12:06 ` [PATCH 2/4] ARM: at91: debug_ll: make UART base address configurable Ahmad Fatoum
2019-02-19 20:42 ` Sam Ravnborg [this message]
2019-02-19 21:10 ` Ahmad Fatoum
2019-02-19 21:12 ` Ahmad Fatoum
2019-02-19 21:30 ` Sam Ravnborg
2019-02-20 7:55 ` Sascha Hauer
2019-02-26 9:09 ` Ahmad Fatoum
2019-02-19 12:06 ` [PATCH 3/4] ARM: at91: fix at91sama5_get_ddram_size for sama5d4 Ahmad Fatoum
2019-02-19 12:06 ` [PATCH 4/4] ARM: at91: remove duplicate get_ddram_size code Ahmad Fatoum
2019-02-24 12:35 ` Sam Ravnborg
2019-02-26 9:10 ` Ahmad Fatoum
2019-02-26 9:56 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219204233.GA14204@ravnborg.org \
--to=sam@ravnborg.org \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox