From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH 4/6] fs: Make use of cdev_flush()
Date: Tue, 26 Feb 2019 11:53:01 -0800 [thread overview]
Message-ID: <20190226195303.24733-4-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20190226195303.24733-1-andrew.smirnov@gmail.com>
Drop extra checks and explicit indirect call in devfs_flush() in
favour of using cdev_flush(), since it already does all of the above.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
fs/devfs.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/devfs.c b/fs/devfs.c
index ce04d0243..d088c1a66 100644
--- a/fs/devfs.c
+++ b/fs/devfs.c
@@ -152,10 +152,7 @@ static int devfs_flush(struct device_d *_dev, FILE *f)
{
struct cdev *cdev = f->priv;
- if (cdev->ops->flush)
- return cdev->ops->flush(cdev);
-
- return 0;
+ return cdev_flush(cdev);
}
static int devfs_ioctl(struct device_d *_dev, FILE *f, int request, void *buf)
--
2.20.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-02-26 19:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 19:52 [PATCH 1/6] fs: Drop needless OOM check Andrey Smirnov
2019-02-26 19:52 ` [PATCH 2/6] fs: ramfs: " Andrey Smirnov
2019-02-26 19:53 ` [PATCH 3/6] fs: Make use of cdev_erase() Andrey Smirnov
2019-02-26 19:53 ` Andrey Smirnov [this message]
2019-02-26 19:53 ` [PATCH 5/6] fs: Drop unused code in fstat() Andrey Smirnov
2019-02-26 19:53 ` [PATCH 6/6] fs: Simplify fd to FILE lookup code Andrey Smirnov
2019-02-27 7:35 ` [PATCH 1/6] fs: Drop needless OOM check Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226195303.24733-4-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox