From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org, Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH] usb: imx: Do not disable VBUS on ehci_register()'s success
Date: Wed, 27 Feb 2019 08:27:58 +0100 [thread overview]
Message-ID: <20190227072758.rkilnd34hisirt6k@pengutronix.de> (raw)
In-Reply-To: <20190225065229.3386-1-andrew.smirnov@gmail.com>
On Sun, Feb 24, 2019 at 10:52:29PM -0800, Andrey Smirnov wrote:
> Original code was written to exit early on ehci_register()'s
> success. As a part of e3eb0c729b, however, it was modified to to early
> exit on failure instead. This resulted in VBUS being erroneously
> disabled after EHCI controller was added, thus breaking USB on some
> i.MX boards (confirmed on ZII's RDU2).
>
> Fixes: e3eb0c729b ("usb: host: ehci: add ehci_unregister()")
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: Vivien Didelot <vivien.didelot@gmail.com>
> ---
> drivers/usb/imx/chipidea-imx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied to master, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-02-27 7:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 6:52 Andrey Smirnov
2019-02-27 7:27 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227072758.rkilnd34hisirt6k@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox