mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] commands: uimage: Drop needless variable in uimage_flush()
@ 2019-02-26 20:06 Andrey Smirnov
  2019-02-27  7:36 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Andrey Smirnov @ 2019-02-26 20:06 UTC (permalink / raw)
  To: barebox; +Cc: Andrey Smirnov

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 commands/uimage.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/commands/uimage.c b/commands/uimage.c
index 7c2dca41e..982da7101 100644
--- a/commands/uimage.c
+++ b/commands/uimage.c
@@ -13,11 +13,7 @@ static int uimage_fd;
 
 static int uimage_flush(void *buf, unsigned int len)
 {
-	int ret;
-
-	ret = write_full(uimage_fd, buf, len);
-
-	return ret;
+	return write_full(uimage_fd, buf, len);
 }
 
 static int do_uimage(int argc, char *argv[])
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] commands: uimage: Drop needless variable in uimage_flush()
  2019-02-26 20:06 [PATCH] commands: uimage: Drop needless variable in uimage_flush() Andrey Smirnov
@ 2019-02-27  7:36 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2019-02-27  7:36 UTC (permalink / raw)
  To: Andrey Smirnov; +Cc: barebox

On Tue, Feb 26, 2019 at 12:06:36PM -0800, Andrey Smirnov wrote:
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  commands/uimage.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/commands/uimage.c b/commands/uimage.c
> index 7c2dca41e..982da7101 100644
> --- a/commands/uimage.c
> +++ b/commands/uimage.c
> @@ -13,11 +13,7 @@ static int uimage_fd;
>  
>  static int uimage_flush(void *buf, unsigned int len)
>  {
> -	int ret;
> -
> -	ret = write_full(uimage_fd, buf, len);
> -
> -	return ret;
> +	return write_full(uimage_fd, buf, len);
>  }
>  
>  static int do_uimage(int argc, char *argv[])
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-02-27  7:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-26 20:06 [PATCH] commands: uimage: Drop needless variable in uimage_flush() Andrey Smirnov
2019-02-27  7:36 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox