From: Sascha Hauer <s.hauer@pengutronix.de>
To: Michael Olbrich <m.olbrich@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] i.MX habv3: add missing includes and make locally used function static
Date: Mon, 4 Mar 2019 09:06:04 +0100 [thread overview]
Message-ID: <20190304080604.zydlpjvytwdg4i5v@pengutronix.de> (raw)
In-Reply-To: <20190302101813.13998-1-m.olbrich@pengutronix.de>
On Sat, Mar 02, 2019 at 11:18:13AM +0100, Michael Olbrich wrote:
> Without this building fails with:
>
> drivers/hab/habv3.c:80:12: error: static declaration of 'imx25_hab_get_status' follows non-static declaration
> In file included from drivers/hab/habv3.c:14:
> include/hab.h:39:5: note: previous declaration of 'imx25_hab_get_status' was here
> drivers/hab/habv3.c:87:1: warning: data definition has no type or storage class
> drivers/hab/habv3.c:87:1: warning: type defaults to 'int' in declaration of 'postmmu_initcall' [-Wimplicit-int]
> drivers/hab/habv3.c:87:1: warning: parameter names (without types) in function declaration
> drivers/hab/habv3.c:80:12: warning: 'imx25_hab_get_status' defined but not used [-Wunused-function]
>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> ---
> drivers/hab/habv3.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied to master, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-03-04 8:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 10:18 Michael Olbrich
2019-03-04 8:06 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304080604.zydlpjvytwdg4i5v@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=m.olbrich@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox