[PATCH] i.MX habv3: add missing includes and make locally used function static

[PATCH] i.MX habv3: add missing includes and make locally used function static

[Michael Olbrich]

Without this building fails with:

drivers/hab/habv3.c:80:12: error: static declaration of 'imx25_hab_get_status' follows non-static declaration
In file included from drivers/hab/habv3.c:14:
include/hab.h:39:5: note: previous declaration of 'imx25_hab_get_status' was here
drivers/hab/habv3.c:87:1: warning: data definition has no type or storage class
drivers/hab/habv3.c:87:1: warning: type defaults to 'int' in declaration of 'postmmu_initcall' [-Wimplicit-int]
drivers/hab/habv3.c:87:1: warning: parameter names (without types) in function declaration
drivers/hab/habv3.c:80:12: warning: 'imx25_hab_get_status' defined but not used [-Wunused-function]

Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
---
 drivers/hab/habv3.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/hab/habv3.c b/drivers/hab/habv3.c
index 47d3caf864ec..f3f94bc44c8c 100644
--- a/drivers/hab/habv3.c
+++ b/drivers/hab/habv3.c
@@ -10,9 +10,11 @@
  */
 #define pr_fmt(fmt) "HABv3: " fmt
 
+#include <init.h>
 #include <common.h>
 #include <hab.h>
 #include <io.h>
+#include <mach/generic.h>
 
 struct hab_status {
 	u8 value;
@@ -55,7 +57,7 @@ static struct hab_status hab_status[] = {
 	{ 0x8e, "algorithm type is either invalid or ortherwise unsupported" },
 };
 
-int imx_habv3_get_status(uint32_t status)
+static int imx_habv3_get_status(uint32_t status)
 {
 	int i;
 
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] i.MX habv3: add missing includes and make locally used function static

[Sascha Hauer]

On Sat, Mar 02, 2019 at 11:18:13AM +0100, Michael Olbrich wrote:
> Without this building fails with:
> 
> drivers/hab/habv3.c:80:12: error: static declaration of 'imx25_hab_get_status' follows non-static declaration
> In file included from drivers/hab/habv3.c:14:
> include/hab.h:39:5: note: previous declaration of 'imx25_hab_get_status' was here
> drivers/hab/habv3.c:87:1: warning: data definition has no type or storage class
> drivers/hab/habv3.c:87:1: warning: type defaults to 'int' in declaration of 'postmmu_initcall' [-Wimplicit-int]
> drivers/hab/habv3.c:87:1: warning: parameter names (without types) in function declaration
> drivers/hab/habv3.c:80:12: warning: 'imx25_hab_get_status' defined but not used [-Wunused-function]
> 
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> ---
>  drivers/hab/habv3.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied to master, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox