mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] ARM: rpi: refactor debug UART Kconfig settings.
@ 2019-02-28 11:39 Tomaz Solc
  2019-03-01  6:42 ` Rouven Czerwinski
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Tomaz Solc @ 2019-02-28 11:39 UTC (permalink / raw)
  To: barebox

This fixes the following issues in the debug UART config for Raspberry
Pi boards:

When debug UART support is enabled, only R.Pi 1 or 2/3 boards
can be supported in a single build. However, this limitation was not
enforced in the "boards to be built" menu. E.g. it was possible to
build a R.Pi 3 image with (non-functional) debug UART support for R.Pi
1.

In contrast to other architectures, R.Pi debug UART config was placed
under the "System Type" menu, not under the "Debugging -> low-level
debugging port". This made this setting easy to miss when enabling low
level debug mesages.
---
 arch/arm/mach-bcm283x/Kconfig                 | 24 ++++------------------
 arch/arm/mach-bcm283x/include/mach/debug_ll.h |  6 +++---
 common/Kconfig                                | 29 +++++++++++++++++++++++++++
 3 files changed, 36 insertions(+), 23 deletions(-)

diff --git a/arch/arm/mach-bcm283x/Kconfig b/arch/arm/mach-bcm283x/Kconfig
index bb5f75dc9..df9206d61 100644
--- a/arch/arm/mach-bcm283x/Kconfig
+++ b/arch/arm/mach-bcm283x/Kconfig
@@ -13,44 +13,28 @@ config MACH_RPI
 	bool "RaspberryPi (BCM2835/ARM1176JZF-S)"
 	select CPU_V6
 	select MACH_RPI_COMMON
+	depends on (!DEBUG_LL) || DEBUG_RPI1_UART
 
 config MACH_RPI2
 	bool "RaspberryPi 2 (BCM2836/CORTEX-A7)"
 	select CPU_V7
 	select MACH_RPI_COMMON
+	depends on (!DEBUG_LL) || DEBUG_RPI2_UART
 
 config MACH_RPI3
 	bool "RaspberryPi 3 (BCM2837/CORTEX-A53)"
 	select CPU_V7
 	select MACH_RPI_COMMON
 	select ARM_SECURE_MONITOR
+	depends on (!DEBUG_LL) || DEBUG_RPI2_UART
 
 config MACH_RPI_CM3
 	bool "RaspberryPi Compute Module 3 (BCM2837/CORTEX-A53)"
 	select CPU_V7
 	select MACH_RPI_COMMON
 	select ARM_SECURE_MONITOR
+	depends on (!DEBUG_LL) || DEBUG_RPI2_UART
 
 endmenu
 
-config MACH_RPI_DEBUG_UART_BASE
-	hex
-	default 0x20201000 if MACH_RPI_DEBUG_UART_RPI
-	default 0x3f201000 if MACH_RPI_DEBUG_UART_RPI2
-
-if DEBUG_LL
-
-choice
-	prompt "Lowlevel debug UART"
-
-config MACH_RPI_DEBUG_UART_RPI
-	bool "use RaspberryPi 1 compatible base"
-
-config MACH_RPI_DEBUG_UART_RPI2
-	bool "use RaspberryPi 2 and 3 compatible base"
-
-endchoice
-
-endif
-
 endif
diff --git a/arch/arm/mach-bcm283x/include/mach/debug_ll.h b/arch/arm/mach-bcm283x/include/mach/debug_ll.h
index a625a8bdb..e4a935800 100644
--- a/arch/arm/mach-bcm283x/include/mach/debug_ll.h
+++ b/arch/arm/mach-bcm283x/include/mach/debug_ll.h
@@ -20,11 +20,11 @@
 
 #include <mach/platform.h>
 
-#ifndef CONFIG_MACH_RPI_DEBUG_UART_BASE
-#define CONFIG_MACH_RPI_DEBUG_UART_BASE 0
+#ifndef CONFIG_DEBUG_RPI_UART_BASE
+#define CONFIG_DEBUG_RPI_UART_BASE 0
 #endif
 
-#define DEBUG_LL_UART_ADDR CONFIG_MACH_RPI_DEBUG_UART_BASE
+#define DEBUG_LL_UART_ADDR CONFIG_DEBUG_RPI_UART_BASE
 
 #include <asm/debug_ll_pl011.h>
 
diff --git a/common/Kconfig b/common/Kconfig
index 21b33f06f..7e2ac2feb 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -1159,6 +1159,29 @@ config DEBUG_SOCFPGA_UART1
 	  Say Y here if you want kernel low-level debugging support
 	  on SOCFPGA(Arria 10) based platforms.
 
+config DEBUG_RPI1_UART
+	bool "RaspberryPi 1 low-level debug UART"
+	depends on ARCH_BCM283X
+	help
+	  Say Y here if you want low-level debugging support on
+	  RaspberryPi 1 boards.
+
+	  Selecting this also limits available choices in "boards to
+	  be built" under "system type". If you want to build images
+	  that work on both RaspberryPi 1 and 2/3, you need to deselect
+	  low-level debug.
+
+config DEBUG_RPI2_UART
+	bool "RaspberryPi 2/3 low-level debug UART"
+	depends on ARCH_BCM283X
+	help
+	  Say Y here if you want low-level debugging support on
+	  RaspberryPi 2 and 3 boards.
+
+	  Selecting this also limits available choices in "boards to
+	  be built" under "system type". If you want to build images
+	  that work on both RaspberryPi 1 and 2/3, you need to deselect
+	  low-level debug.
 
 endchoice
 
@@ -1209,6 +1232,12 @@ config DEBUG_SOCFPGA_UART_PHYS_ADDR
 	default 0xffc02100 if DEBUG_SOCFPGA_UART1
 	depends on ARCH_SOCFPGA
 
+config DEBUG_RPI_UART_BASE
+	hex
+	default 0x20201000 if DEBUG_RPI1_UART
+	default 0x3f201000 if DEBUG_RPI2_UART
+	depends on ARCH_BCM283X
+
 config DEBUG_SOCFPGA_UART_CLOCK
 	int "SoCFPGA UART debug clock" if DEBUG_LL
 	default 100000000 if ARCH_SOCFPGA_CYCLONE5
-- 
2.11.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: rpi: refactor debug UART Kconfig settings.
  2019-02-28 11:39 [PATCH] ARM: rpi: refactor debug UART Kconfig settings Tomaz Solc
@ 2019-03-01  6:42 ` Rouven Czerwinski
  2019-03-01 10:58 ` Roland Hieber
  2019-03-04  8:04 ` Sascha Hauer
  2 siblings, 0 replies; 6+ messages in thread
From: Rouven Czerwinski @ 2019-03-01  6:42 UTC (permalink / raw)
  To: Tomaz Solc, barebox

On Thu, 2019-02-28 at 12:39 +0100, Tomaz Solc wrote:
> This fixes the following issues in the debug UART config for
> Raspberry
> Pi boards:
> 
> When debug UART support is enabled, only R.Pi 1 or 2/3 boards
> can be supported in a single build. However, this limitation was not
> enforced in the "boards to be built" menu. E.g. it was possible to
> build a R.Pi 3 image with (non-functional) debug UART support for
> R.Pi
> 1.
> 
> In contrast to other architectures, R.Pi debug UART config was placed
> under the "System Type" menu, not under the "Debugging -> low-level
> debugging port". This made this setting easy to miss when enabling
> low
> level debug mesages.
> ---
>  arch/arm/mach-bcm283x/Kconfig                 | 24 ++++-------------
> -----
>  arch/arm/mach-bcm283x/include/mach/debug_ll.h |  6 +++---
>  common/Kconfig                                | 29
> +++++++++++++++++++++++++++
>  3 files changed, 36 insertions(+), 23 deletions(-)
> 
> diff --git a/arch/arm/mach-bcm283x/Kconfig b/arch/arm/mach-
> bcm283x/Kconfig
> index bb5f75dc9..df9206d61 100644
> --- a/arch/arm/mach-bcm283x/Kconfig
> +++ b/arch/arm/mach-bcm283x/Kconfig
> @@ -13,44 +13,28 @@ config MACH_RPI
>  	bool "RaspberryPi (BCM2835/ARM1176JZF-S)"
>  	select CPU_V6
>  	select MACH_RPI_COMMON
> +	depends on (!DEBUG_LL) || DEBUG_RPI1_UART
>  
>  config MACH_RPI2
>  	bool "RaspberryPi 2 (BCM2836/CORTEX-A7)"
>  	select CPU_V7
>  	select MACH_RPI_COMMON
> +	depends on (!DEBUG_LL) || DEBUG_RPI2_UART
>  
>  config MACH_RPI3
>  	bool "RaspberryPi 3 (BCM2837/CORTEX-A53)"
>  	select CPU_V7
>  	select MACH_RPI_COMMON
>  	select ARM_SECURE_MONITOR
> +	depends on (!DEBUG_LL) || DEBUG_RPI2_UART
>  
>  config MACH_RPI_CM3
>  	bool "RaspberryPi Compute Module 3 (BCM2837/CORTEX-A53)"
>  	select CPU_V7
>  	select MACH_RPI_COMMON
>  	select ARM_SECURE_MONITOR
> +	depends on (!DEBUG_LL) || DEBUG_RPI2_UART
>  
>  endmenu
>  
> -config MACH_RPI_DEBUG_UART_BASE
> -	hex
> -	default 0x20201000 if MACH_RPI_DEBUG_UART_RPI
> -	default 0x3f201000 if MACH_RPI_DEBUG_UART_RPI2
> -
> -if DEBUG_LL
> -
> -choice
> -	prompt "Lowlevel debug UART"
> -
> -config MACH_RPI_DEBUG_UART_RPI
> -	bool "use RaspberryPi 1 compatible base"
> -
> -config MACH_RPI_DEBUG_UART_RPI2
> -	bool "use RaspberryPi 2 and 3 compatible base"
> -
> -endchoice
> -
> -endif
> -
>  endif
> diff --git a/arch/arm/mach-bcm283x/include/mach/debug_ll.h
> b/arch/arm/mach-bcm283x/include/mach/debug_ll.h
> index a625a8bdb..e4a935800 100644
> --- a/arch/arm/mach-bcm283x/include/mach/debug_ll.h
> +++ b/arch/arm/mach-bcm283x/include/mach/debug_ll.h
> @@ -20,11 +20,11 @@
>  
>  #include <mach/platform.h>
>  
> -#ifndef CONFIG_MACH_RPI_DEBUG_UART_BASE
> -#define CONFIG_MACH_RPI_DEBUG_UART_BASE 0
> +#ifndef CONFIG_DEBUG_RPI_UART_BASE
> +#define CONFIG_DEBUG_RPI_UART_BASE 0
>  #endif
>  
> -#define DEBUG_LL_UART_ADDR CONFIG_MACH_RPI_DEBUG_UART_BASE
> +#define DEBUG_LL_UART_ADDR CONFIG_DEBUG_RPI_UART_BASE
>  
>  #include <asm/debug_ll_pl011.h>
>  
> diff --git a/common/Kconfig b/common/Kconfig
> index 21b33f06f..7e2ac2feb 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -1159,6 +1159,29 @@ config DEBUG_SOCFPGA_UART1
>  	  Say Y here if you want kernel low-level debugging support
>  	  on SOCFPGA(Arria 10) based platforms.
>  
> +config DEBUG_RPI1_UART
> +	bool "RaspberryPi 1 low-level debug UART"
> +	depends on ARCH_BCM283X
> +	help
> +	  Say Y here if you want low-level debugging support on
> +	  RaspberryPi 1 boards.
> +
> +	  Selecting this also limits available choices in "boards to
> +	  be built" under "system type". If you want to build images
> +	  that work on both RaspberryPi 1 and 2/3, you need to
> deselect
> +	  low-level debug.
> +
> +config DEBUG_RPI2_UART
> +	bool "RaspberryPi 2/3 low-level debug UART"
> +	depends on ARCH_BCM283X
> +	help
> +	  Say Y here if you want low-level debugging support on
> +	  RaspberryPi 2 and 3 boards.
> +
> +	  Selecting this also limits available choices in "boards to
> +	  be built" under "system type". If you want to build images
> +	  that work on both RaspberryPi 1 and 2/3, you need to
> deselect
> +	  low-level debug.
>  
>  endchoice
>  
> @@ -1209,6 +1232,12 @@ config DEBUG_SOCFPGA_UART_PHYS_ADDR
>  	default 0xffc02100 if DEBUG_SOCFPGA_UART1
>  	depends on ARCH_SOCFPGA
>  
> +config DEBUG_RPI_UART_BASE
> +	hex
> +	default 0x20201000 if DEBUG_RPI1_UART
> +	default 0x3f201000 if DEBUG_RPI2_UART
> +	depends on ARCH_BCM283X
> +
>  config DEBUG_SOCFPGA_UART_CLOCK
>  	int "SoCFPGA UART debug clock" if DEBUG_LL
>  	default 100000000 if ARCH_SOCFPGA_CYCLONE5

Reviewed-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: rpi: refactor debug UART Kconfig settings.
  2019-02-28 11:39 [PATCH] ARM: rpi: refactor debug UART Kconfig settings Tomaz Solc
  2019-03-01  6:42 ` Rouven Czerwinski
@ 2019-03-01 10:58 ` Roland Hieber
  2019-03-04  8:04 ` Sascha Hauer
  2 siblings, 0 replies; 6+ messages in thread
From: Roland Hieber @ 2019-03-01 10:58 UTC (permalink / raw)
  To: Tomaz Solc; +Cc: barebox

On Thu, Feb 28, 2019 at 12:39:00PM +0100, Tomaz Solc wrote:
> This fixes the following issues in the debug UART config for Raspberry
> Pi boards:
> 
> When debug UART support is enabled, only R.Pi 1 or 2/3 boards
> can be supported in a single build. However, this limitation was not
> enforced in the "boards to be built" menu. E.g. it was possible to
> build a R.Pi 3 image with (non-functional) debug UART support for R.Pi
> 1.
> 
> In contrast to other architectures, R.Pi debug UART config was placed
> under the "System Type" menu, not under the "Debugging -> low-level
> debugging port". This made this setting easy to miss when enabling low
> level debug mesages.
> ---
>  arch/arm/mach-bcm283x/Kconfig                 | 24 ++++------------------
>  arch/arm/mach-bcm283x/include/mach/debug_ll.h |  6 +++---
>  common/Kconfig                                | 29 +++++++++++++++++++++++++++
>  3 files changed, 36 insertions(+), 23 deletions(-)

Reviewed-by: Roland Hieber <rhi@pengutronix.de>

> 
> diff --git a/arch/arm/mach-bcm283x/Kconfig b/arch/arm/mach-bcm283x/Kconfig
> index bb5f75dc9..df9206d61 100644
> --- a/arch/arm/mach-bcm283x/Kconfig
> +++ b/arch/arm/mach-bcm283x/Kconfig
> @@ -13,44 +13,28 @@ config MACH_RPI
>  	bool "RaspberryPi (BCM2835/ARM1176JZF-S)"
>  	select CPU_V6
>  	select MACH_RPI_COMMON
> +	depends on (!DEBUG_LL) || DEBUG_RPI1_UART
>  
>  config MACH_RPI2
>  	bool "RaspberryPi 2 (BCM2836/CORTEX-A7)"
>  	select CPU_V7
>  	select MACH_RPI_COMMON
> +	depends on (!DEBUG_LL) || DEBUG_RPI2_UART
>  
>  config MACH_RPI3
>  	bool "RaspberryPi 3 (BCM2837/CORTEX-A53)"
>  	select CPU_V7
>  	select MACH_RPI_COMMON
>  	select ARM_SECURE_MONITOR
> +	depends on (!DEBUG_LL) || DEBUG_RPI2_UART
>  
>  config MACH_RPI_CM3
>  	bool "RaspberryPi Compute Module 3 (BCM2837/CORTEX-A53)"
>  	select CPU_V7
>  	select MACH_RPI_COMMON
>  	select ARM_SECURE_MONITOR
> +	depends on (!DEBUG_LL) || DEBUG_RPI2_UART
>  
>  endmenu
>  
> -config MACH_RPI_DEBUG_UART_BASE
> -	hex
> -	default 0x20201000 if MACH_RPI_DEBUG_UART_RPI
> -	default 0x3f201000 if MACH_RPI_DEBUG_UART_RPI2
> -
> -if DEBUG_LL
> -
> -choice
> -	prompt "Lowlevel debug UART"
> -
> -config MACH_RPI_DEBUG_UART_RPI
> -	bool "use RaspberryPi 1 compatible base"
> -
> -config MACH_RPI_DEBUG_UART_RPI2
> -	bool "use RaspberryPi 2 and 3 compatible base"
> -
> -endchoice
> -
> -endif
> -
>  endif
> diff --git a/arch/arm/mach-bcm283x/include/mach/debug_ll.h b/arch/arm/mach-bcm283x/include/mach/debug_ll.h
> index a625a8bdb..e4a935800 100644
> --- a/arch/arm/mach-bcm283x/include/mach/debug_ll.h
> +++ b/arch/arm/mach-bcm283x/include/mach/debug_ll.h
> @@ -20,11 +20,11 @@
>  
>  #include <mach/platform.h>
>  
> -#ifndef CONFIG_MACH_RPI_DEBUG_UART_BASE
> -#define CONFIG_MACH_RPI_DEBUG_UART_BASE 0
> +#ifndef CONFIG_DEBUG_RPI_UART_BASE
> +#define CONFIG_DEBUG_RPI_UART_BASE 0
>  #endif
>  
> -#define DEBUG_LL_UART_ADDR CONFIG_MACH_RPI_DEBUG_UART_BASE
> +#define DEBUG_LL_UART_ADDR CONFIG_DEBUG_RPI_UART_BASE
>  
>  #include <asm/debug_ll_pl011.h>
>  
> diff --git a/common/Kconfig b/common/Kconfig
> index 21b33f06f..7e2ac2feb 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -1159,6 +1159,29 @@ config DEBUG_SOCFPGA_UART1
>  	  Say Y here if you want kernel low-level debugging support
>  	  on SOCFPGA(Arria 10) based platforms.
>  
> +config DEBUG_RPI1_UART
> +	bool "RaspberryPi 1 low-level debug UART"
> +	depends on ARCH_BCM283X
> +	help
> +	  Say Y here if you want low-level debugging support on
> +	  RaspberryPi 1 boards.
> +
> +	  Selecting this also limits available choices in "boards to
> +	  be built" under "system type". If you want to build images
> +	  that work on both RaspberryPi 1 and 2/3, you need to deselect
> +	  low-level debug.
> +
> +config DEBUG_RPI2_UART
> +	bool "RaspberryPi 2/3 low-level debug UART"
> +	depends on ARCH_BCM283X
> +	help
> +	  Say Y here if you want low-level debugging support on
> +	  RaspberryPi 2 and 3 boards.
> +
> +	  Selecting this also limits available choices in "boards to
> +	  be built" under "system type". If you want to build images
> +	  that work on both RaspberryPi 1 and 2/3, you need to deselect
> +	  low-level debug.
>  
>  endchoice
>  
> @@ -1209,6 +1232,12 @@ config DEBUG_SOCFPGA_UART_PHYS_ADDR
>  	default 0xffc02100 if DEBUG_SOCFPGA_UART1
>  	depends on ARCH_SOCFPGA
>  
> +config DEBUG_RPI_UART_BASE
> +	hex
> +	default 0x20201000 if DEBUG_RPI1_UART
> +	default 0x3f201000 if DEBUG_RPI2_UART
> +	depends on ARCH_BCM283X
> +
>  config DEBUG_SOCFPGA_UART_CLOCK
>  	int "SoCFPGA UART debug clock" if DEBUG_LL
>  	default 100000000 if ARCH_SOCFPGA_CYCLONE5
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: rpi: refactor debug UART Kconfig settings.
  2019-02-28 11:39 [PATCH] ARM: rpi: refactor debug UART Kconfig settings Tomaz Solc
  2019-03-01  6:42 ` Rouven Czerwinski
  2019-03-01 10:58 ` Roland Hieber
@ 2019-03-04  8:04 ` Sascha Hauer
  2019-03-05  9:13   ` Tomaž Šolc
  2 siblings, 1 reply; 6+ messages in thread
From: Sascha Hauer @ 2019-03-04  8:04 UTC (permalink / raw)
  To: Tomaz Solc; +Cc: barebox

On Thu, Feb 28, 2019 at 12:39:00PM +0100, Tomaz Solc wrote:
> This fixes the following issues in the debug UART config for Raspberry
> Pi boards:
> 
> When debug UART support is enabled, only R.Pi 1 or 2/3 boards
> can be supported in a single build. However, this limitation was not
> enforced in the "boards to be built" menu. E.g. it was possible to
> build a R.Pi 3 image with (non-functional) debug UART support for R.Pi
> 1.
> 
> In contrast to other architectures, R.Pi debug UART config was placed
> under the "System Type" menu, not under the "Debugging -> low-level
> debugging port". This made this setting easy to miss when enabling low
> level debug mesages.
> ---
> +config DEBUG_RPI1_UART
> +	bool "RaspberryPi 1 low-level debug UART"
> +	depends on ARCH_BCM283X
> +	help
> +	  Say Y here if you want low-level debugging support on
> +	  RaspberryPi 1 boards.
> +
> +	  Selecting this also limits available choices in "boards to
> +	  be built" under "system type". If you want to build images
> +	  that work on both RaspberryPi 1 and 2/3, you need to deselect
> +	  low-level debug.

The idea behind debug_ll is that when you enable it the resulting image
will only work on the system you chose the UART for. It's the same in
the Kernel and we should probably adopt the text for barebox:

          Note that selecting this option will limit the kernel to a single
          UART definition, as specified below. Attempting to boot the kernel
          image on a different platform *will not work*, so this option should
          not be enabled for kernels that are intended to be portable.

So that said, even with a debug UART enabled for Rpi1 we should still
allow to build for Rpi2/3 although we know it won't work there.

The reason is you might get failures only when multiple SoCs are
selected. In that case you only want to enable early debugging support
(for the SoC you are currently testing on) without changing other things
in the config which might make your errors disappear.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: rpi: refactor debug UART Kconfig settings.
  2019-03-04  8:04 ` Sascha Hauer
@ 2019-03-05  9:13   ` Tomaž Šolc
  2019-03-06  9:45     ` Sascha Hauer
  0 siblings, 1 reply; 6+ messages in thread
From: Tomaž Šolc @ 2019-03-05  9:13 UTC (permalink / raw)
  To: barebox

On 4. 03. 19 09:04, Sascha Hauer wrote:
> So that said, even with a debug UART enabled for Rpi1 we should still
> allow to build for Rpi2/3 although we know it won't work there.
> 
> The reason is you might get failures only when multiple SoCs are
> selected. In that case you only want to enable early debugging support
> (for the SoC you are currently testing on) without changing other things
> in the config which might make your errors disappear.

Thanks for the clarification. I've sent another patch series that 
removes the restriction for board builds and adds the help text.

On the topic of the debug UART, I've also noticed that it's a bit tricky 
to get it running on Raspberry Pi 3. The problem is that the debug UART 
is using PL011 hardware, but the console is now using miniuart.

In addition to enabling it in menuconfig, I have to reverse the commit 
ab76f9d0 (switch to miniuart for stdout in the device tree) and keep 
"dtoverlay=pi3-miniuart-bt" in "config.txt" (instruction for this was 
removed in f1330536).

Best regards
Tomaž

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: rpi: refactor debug UART Kconfig settings.
  2019-03-05  9:13   ` Tomaž Šolc
@ 2019-03-06  9:45     ` Sascha Hauer
  0 siblings, 0 replies; 6+ messages in thread
From: Sascha Hauer @ 2019-03-06  9:45 UTC (permalink / raw)
  To: Tomaž Šolc; +Cc: barebox

Hi Tomaž,

On Tue, Mar 05, 2019 at 10:13:04AM +0100, Tomaž Šolc wrote:
> On 4. 03. 19 09:04, Sascha Hauer wrote:
> > So that said, even with a debug UART enabled for Rpi1 we should still
> > allow to build for Rpi2/3 although we know it won't work there.
> > 
> > The reason is you might get failures only when multiple SoCs are
> > selected. In that case you only want to enable early debugging support
> > (for the SoC you are currently testing on) without changing other things
> > in the config which might make your errors disappear.
> 
> Thanks for the clarification. I've sent another patch series that removes
> the restriction for board builds and adds the help text.
> 
> On the topic of the debug UART, I've also noticed that it's a bit tricky to
> get it running on Raspberry Pi 3. The problem is that the debug UART is
> using PL011 hardware, but the console is now using miniuart.
> 
> In addition to enabling it in menuconfig, I have to reverse the commit
> ab76f9d0 (switch to miniuart for stdout in the device tree) and keep
> "dtoverlay=pi3-miniuart-bt" in "config.txt" (instruction for this was
> removed in f1330536).

I just sent a series based on your patches adding mini UART support for
the rpi3. I need the basic ns16550 early debugging code for Layerscape
anyway, so it's a win-win ;) Tested on Layerscape, but not on rpi3, so
I would be glad if you could test it.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-06  9:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-28 11:39 [PATCH] ARM: rpi: refactor debug UART Kconfig settings Tomaz Solc
2019-03-01  6:42 ` Rouven Czerwinski
2019-03-01 10:58 ` Roland Hieber
2019-03-04  8:04 ` Sascha Hauer
2019-03-05  9:13   ` Tomaž Šolc
2019-03-06  9:45     ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox