mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] PCI: dwc: tune down link up messages
@ 2019-03-05  9:45 Lucas Stach
  2019-03-07  7:19 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Lucas Stach @ 2019-03-05  9:45 UTC (permalink / raw)
  To: barebox

This function may be called repeatedly while establishing the link,
so printing a message each time a working link is found can add quite
a bit of noise. Tune those messages down to the debug level.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/pci/pcie-designware.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/pcie-designware.c b/drivers/pci/pcie-designware.c
index aaea316e9095..c6d19559f437 100644
--- a/drivers/pci/pcie-designware.c
+++ b/drivers/pci/pcie-designware.c
@@ -195,7 +195,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci)
 	/* Check if the link is up or not */
 	for (retries = 0; retries < LINK_WAIT_MAX_RETRIES; retries++) {
 		if (dw_pcie_link_up(pci)) {
-			dev_info(pci->dev, "Link up\n");
+			dev_dbg(pci->dev, "Link up\n");
 			return 0;
 		}
 		udelay(LINK_WAIT_USLEEP_MAX);
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] PCI: dwc: tune down link up messages
  2019-03-05  9:45 [PATCH] PCI: dwc: tune down link up messages Lucas Stach
@ 2019-03-07  7:19 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2019-03-07  7:19 UTC (permalink / raw)
  To: Lucas Stach; +Cc: barebox

On Tue, Mar 05, 2019 at 10:45:15AM +0100, Lucas Stach wrote:
> This function may be called repeatedly while establishing the link,
> so printing a message each time a working link is found can add quite
> a bit of noise. Tune those messages down to the debug level.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  drivers/pci/pcie-designware.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/pci/pcie-designware.c b/drivers/pci/pcie-designware.c
> index aaea316e9095..c6d19559f437 100644
> --- a/drivers/pci/pcie-designware.c
> +++ b/drivers/pci/pcie-designware.c
> @@ -195,7 +195,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci)
>  	/* Check if the link is up or not */
>  	for (retries = 0; retries < LINK_WAIT_MAX_RETRIES; retries++) {
>  		if (dw_pcie_link_up(pci)) {
> -			dev_info(pci->dev, "Link up\n");
> +			dev_dbg(pci->dev, "Link up\n");
>  			return 0;
>  		}
>  		udelay(LINK_WAIT_USLEEP_MAX);
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-07  7:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-05  9:45 [PATCH] PCI: dwc: tune down link up messages Lucas Stach
2019-03-07  7:19 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox