From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1nVi-000753-0z for barebox@lists.infradead.org; Thu, 07 Mar 2019 07:32:12 +0000 Date: Thu, 7 Mar 2019 08:32:07 +0100 From: Sascha Hauer Message-ID: <20190307073207.jmj63dxxfkqif7fz@pengutronix.de> References: <20190219121018.29736-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/2] images: pbl: verify CONFIG_BAREBOX_MAX_IMAGE_SIZE is not exceeded To: Ahmad Fatoum Cc: barebox@lists.infradead.org On Mon, Mar 04, 2019 at 03:16:51PM +0100, Ahmad Fatoum wrote: > Hello, > > On 19/2/19 13:10, Ahmad Fatoum wrote: > > For platforms such as the at91, the boot ROM imposes an upper limit > > on barebox file size. Prior to 5a1a5ed253 ("ARM: images: use piggydata"), > > BAREBOX_MAX_PBLX_SIZE seems to have been the way to go for limiting > > the size of the final barebox binary when using the PBL. > > With pblx removed, this variable is of no use, so have the existing > > BAREBOX_MAX_IMAGE_SIZE replace its functionality. > > > > Currently BAREBOX_MAX_IMAGE_SIZE is only checked against in the non-PBL > > case, so add a check in the PBL case as well. > > > > Signed-off-by: Ahmad Fatoum > > --- > > arch/arm/configs/am335x_mlo_defconfig | 2 +- > > common/Kconfig | 10 ---------- > > images/Makefile | 1 + > > 3 files changed, 2 insertions(+), 11 deletions(-) > > > > any news on these two patches? I applied the first one as I think it does nothing wrong. I am always hesitating to apply such patches because I think we need to do this better. For example when doing multi image builds different ROMs with different size limitations might be involved, so putting the limitation in Kconfig is wrong. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox