From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH 00/26] USB storage improvements
Date: Thu, 7 Mar 2019 00:00:10 -0800 [thread overview]
Message-ID: <20190307080036.28028-1-andrew.smirnov@gmail.com> (raw)
Everyone:
While creating fix found in "usb: storage: Don't use "unsigned long"
for 32-bit values" I spent some time reading code of our USB storage
implementation. The other 25 patches is the result of that effort and
my attempt to improve/simplify that codebase. Hopefuly each patch is
self-explanatory.
Feedback is welcome!
Thanks,
Andrey Smirnov
Andrey Smirnov (26):
usb: storage: Simplify memory allocation in usb_stor_probe()
usb: storage: Replace custom debug tracing with dev_dbg
usb: storage: Don't use "unsigned long" for 32-bit values
usb: storage: Make usb_stor_read_capacity() a standalone function
usb: storage: Make usb_stor_inquiry() a standalone function
usb: storage: Make usb_stor_test_unit_ready() a standalone function
usb: storage: Make usb_stor_read_10() a standalone function
usb: storage: Make usb_stor_write_10() a standalone function
usb: storage: Drop extra call to transport in usb_stor_write_10()
usb: storage: Share code for READ(10) and WRITE(10)
usb: storage: Make usb_stor_request_sense() a standalone function
usb: storage: Remove unused variables
usb: storage: Drop struct SCSI_cmd_block
usb: hub: Do not include <scsi.h>
ata: ahci: Do not include <scsi.h>
usb: storage: Drop unused fields in struct us_data
usb: storage: Drop unused us_blkdev_list
usb: storage: Introduce usb_stor_transport()
usb: storage: Use put_unaligned_be* helpers
usb: Drop usb_disable_asynch()
usb: storage: Drop unnecessary check in usb_stor_blk_io()
usb: storage: Drop needless macro
usb: storage: Use simple boolean to speficy read vs. write operation
usb: storage: Simplify I/O loop in usb_stor_blk_io()
usb: storage: Drop unnecessary assignment
usb: storage: Inline usb_limit_blk_cnt()
drivers/ata/ahci.c | 1 -
drivers/usb/core/hub.c | 1 -
drivers/usb/core/usb.c | 24 +-
drivers/usb/storage/transport.c | 87 +++---
drivers/usb/storage/transport.h | 2 +-
drivers/usb/storage/usb.c | 484 ++++++++++++++------------------
drivers/usb/storage/usb.h | 19 +-
include/scsi.h | 22 --
include/usb/usb.h | 1 -
9 files changed, 265 insertions(+), 376 deletions(-)
--
2.20.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2019-03-07 8:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 8:00 Andrey Smirnov [this message]
2019-03-07 8:00 ` [PATCH 01/26] usb: storage: Simplify memory allocation in usb_stor_probe() Andrey Smirnov
2019-03-07 8:00 ` [PATCH 02/26] usb: storage: Replace custom debug tracing with dev_dbg Andrey Smirnov
2019-03-07 8:00 ` [PATCH 03/26] usb: storage: Don't use "unsigned long" for 32-bit values Andrey Smirnov
2019-03-07 8:00 ` [PATCH 04/26] usb: storage: Make usb_stor_read_capacity() a standalone function Andrey Smirnov
2019-03-07 8:00 ` [PATCH 05/26] usb: storage: Make usb_stor_inquiry() " Andrey Smirnov
2019-03-07 8:00 ` [PATCH 06/26] usb: storage: Make usb_stor_test_unit_ready() " Andrey Smirnov
2019-03-07 8:00 ` [PATCH 07/26] usb: storage: Make usb_stor_read_10() " Andrey Smirnov
2019-03-07 8:00 ` [PATCH 08/26] usb: storage: Make usb_stor_write_10() " Andrey Smirnov
2019-03-07 8:00 ` [PATCH 09/26] usb: storage: Drop extra call to transport in usb_stor_write_10() Andrey Smirnov
2019-03-07 8:00 ` [PATCH 10/26] usb: storage: Share code for READ(10) and WRITE(10) Andrey Smirnov
2019-03-07 8:00 ` [PATCH 11/26] usb: storage: Make usb_stor_request_sense() a standalone function Andrey Smirnov
2019-03-07 8:00 ` [PATCH 12/26] usb: storage: Remove unused variables Andrey Smirnov
2019-03-07 8:00 ` [PATCH 13/26] usb: storage: Drop struct SCSI_cmd_block Andrey Smirnov
2019-03-07 8:00 ` [PATCH 14/26] usb: hub: Do not include <scsi.h> Andrey Smirnov
2019-03-07 8:00 ` [PATCH 15/26] ata: ahci: " Andrey Smirnov
2019-03-07 8:00 ` [PATCH 16/26] usb: storage: Drop unused fields in struct us_data Andrey Smirnov
2019-03-07 8:00 ` [PATCH 17/26] usb: storage: Drop unused us_blkdev_list Andrey Smirnov
2019-03-07 8:00 ` [PATCH 18/26] usb: storage: Introduce usb_stor_transport() Andrey Smirnov
2019-03-07 8:00 ` [PATCH 19/26] usb: storage: Use put_unaligned_be* helpers Andrey Smirnov
2019-03-07 8:00 ` [PATCH 20/26] usb: Drop usb_disable_asynch() Andrey Smirnov
2019-03-07 8:00 ` [PATCH 21/26] usb: storage: Drop unnecessary check in usb_stor_blk_io() Andrey Smirnov
2019-03-07 8:00 ` [PATCH 22/26] usb: storage: Drop needless macro Andrey Smirnov
2019-03-07 8:00 ` [PATCH 23/26] usb: storage: Use simple boolean to speficy read vs. write operation Andrey Smirnov
2019-03-07 8:00 ` [PATCH 24/26] usb: storage: Simplify I/O loop in usb_stor_blk_io() Andrey Smirnov
2019-03-07 8:00 ` [PATCH 25/26] usb: storage: Drop unnecessary assignment Andrey Smirnov
2019-03-07 8:00 ` [PATCH 26/26] usb: storage: Inline usb_limit_blk_cnt() Andrey Smirnov
2019-03-11 7:11 ` [PATCH 00/26] USB storage improvements Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307080036.28028-1-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox