From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>, barebox@lists.infradead.org
Subject: Re: [PATCH 0/3] Earlycon command line option support
Date: Wed, 13 Mar 2019 09:45:15 +0100 [thread overview]
Message-ID: <20190313084515.3uae3luepv4ixqii@pengutronix.de> (raw)
In-Reply-To: <1552383817.2453.25.camel@pengutronix.de>
On Tue, Mar 12, 2019 at 10:43:37AM +0100, Lucas Stach wrote:
> Hi Andrey,
>
> Am Dienstag, den 12.03.2019, 00:45 -0700 schrieb Andrey Smirnov:
> > Everyone:
> >
> > This small series is something I came up with to avoid having to look
> > up the syntax and manually specify earlycon kernel command line option
> > every time I needed it. The series is purely optional in case I am not
> > the only one who thinks this is useful.
> >
> > Feedback is welcome!
> >
> > Thanks,
> > Andrey Smirnov
> >
> > Andrey Smirnov (3):
> > console: Add plumbing to expose earlycon/bootconsole parameter
> > serial: i.MX: Add code to export "earlycon" setting
> > serial: lpuart: Add code to export "earlycon" setting
> >
> > Documentation/user/variables.rst | 1 +
> > common/console.c | 25 +++++++++++++++++++++++++
> > drivers/serial/serial_imx.c | 3 +++
> > drivers/serial/serial_lpuart.c | 1 +
> > include/console.h | 1 +
> > 5 files changed, 31 insertions(+)
>
> I don't think any of this is necessary. For DT based platforms earlycon
> will use the console specified via the "stdout-path" property, so it's
> entirely sufficient to add "earlycon" to the kernel command line and
> the kernel will do the right thing. No need for any more elaborate
> kernel commandline options.
I'm with Lucas here unless some good arguments come up why this is
needed.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-03-13 8:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 7:45 Andrey Smirnov
2019-03-12 7:45 ` [PATCH 1/3] console: Add plumbing to expose earlycon/bootconsole parameter Andrey Smirnov
2019-03-12 7:45 ` [PATCH 2/3] serial: i.MX: Add code to export "earlycon" setting Andrey Smirnov
2019-03-12 7:45 ` [PATCH 3/3] serial: lpuart: " Andrey Smirnov
2019-03-12 9:43 ` [PATCH 0/3] Earlycon command line option support Lucas Stach
2019-03-13 8:45 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190313084515.3uae3luepv4ixqii@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=l.stach@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox