From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: i.MX7: Make sure CNTFRQ is initialized early enough
Date: Mon, 18 Mar 2019 09:02:57 +0100 [thread overview]
Message-ID: <20190318080257.oqogbpmcc3ykcpmd@pengutronix.de> (raw)
In-Reply-To: <20190313033147.20507-1-andrew.smirnov@gmail.com>
On Tue, Mar 12, 2019 at 08:31:46PM -0700, Andrey Smirnov wrote:
> We need to make sure that CNTFRQ is initialized before corresponding
> clocksource driver tries to use it, otherwise we'll end up crashing
> due to division by zero.
>
> We can't convert imx7_timer_init() to be an initcall since it is an
> i.MX7 specific task, but CPU type information won't be availible until
> after imx_init() gets executed at postcore_initcall() level. To solve
> this move all of the necessary code to be a part of
> imx7_cpu_lowlevel_init().
>
> Note, that original code both hardcoded frequency value to 8MHz as
> well as tried to write it to the first element of the frequency mode
> table which appears to be read-only on i.MX7. So while we are at it,
> simplify the code by adding set_cntfrq() implementation for ARMv7 and
> copy the code we already using for i.MX8MQ.
>
> Fixes: dece70752 ("clocksource: Enable architected timer support for CPU_V7")
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> arch/arm/include/asm/system.h | 5 +++++
> arch/arm/mach-imx/cpu_init.c | 13 +++++++++++++
> arch/arm/mach-imx/imx7.c | 35 -----------------------------------
> 3 files changed, 18 insertions(+), 35 deletions(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-03-18 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 3:31 Andrey Smirnov
2019-03-13 3:31 ` [PATCH 2/2] ARM: i.MX8MQ: Don't use cpu_is_mx8mq() at core_initcall level Andrey Smirnov
2019-03-18 8:02 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318080257.oqogbpmcc3ykcpmd@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox