mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] mci: imx-esdhc-pbl: initialize is_be
@ 2019-03-15 14:08 Christian Hemp
  2019-03-18  8:45 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Hemp @ 2019-03-15 14:08 UTC (permalink / raw)
  To: barebox

Initialize is_be, otherwise the value of is_be is undefined.
So it is possible that the i.MX8 will not boot because the bigendian
functions are used.

Signed-off-by: Christian Hemp <c.hemp@phytec.de>
---
 drivers/mci/imx-esdhc-pbl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mci/imx-esdhc-pbl.c b/drivers/mci/imx-esdhc-pbl.c
index f77530d..8a03c5f 100644
--- a/drivers/mci/imx-esdhc-pbl.c
+++ b/drivers/mci/imx-esdhc-pbl.c
@@ -366,6 +366,7 @@ int imx6_esdhc_start_image(int instance)
 		return -EINVAL;
 	}
 
+	esdhc.is_be = 0;
 	esdhc.is_mx6 = 1;
 
 	return esdhc_start_image(&esdhc, 0x10000000, 0x10000000, 0);
@@ -398,6 +399,7 @@ int imx8_esdhc_start_image(int instance)
 		return -EINVAL;
 	}
 
+	esdhc.is_be = 0;
 	esdhc.is_mx6 = 1;
 
 	return esdhc_start_image(&esdhc, MX8MQ_DDR_CSD1_BASE_ADDR,
-- 
2.7.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mci: imx-esdhc-pbl: initialize is_be
  2019-03-15 14:08 [PATCH] mci: imx-esdhc-pbl: initialize is_be Christian Hemp
@ 2019-03-18  8:45 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2019-03-18  8:45 UTC (permalink / raw)
  To: Christian Hemp; +Cc: barebox

On Fri, Mar 15, 2019 at 03:08:52PM +0100, Christian Hemp wrote:
> Initialize is_be, otherwise the value of is_be is undefined.
> So it is possible that the i.MX8 will not boot because the bigendian
> functions are used.
> 
> Signed-off-by: Christian Hemp <c.hemp@phytec.de>
> ---
>  drivers/mci/imx-esdhc-pbl.c | 2 ++
>  1 file changed, 2 insertions(+)

Applied to master, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-18  8:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-15 14:08 [PATCH] mci: imx-esdhc-pbl: initialize is_be Christian Hemp
2019-03-18  8:45 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox