mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Roland Hieber <rhi@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 05/11] ARM: boards: Harmonize barebox_arm_reset_vector() prototype
Date: Mon, 18 Mar 2019 11:41:07 +0100	[thread overview]
Message-ID: <20190318104107.w3brsm7vfxvjswlt@pengutronix.de> (raw)
In-Reply-To: <20190318103148.g74dwta7od4226ee@pengutronix.de>

On Mon, Mar 18, 2019 at 11:31:48AM +0100, Roland Hieber wrote:
> On Mon, Mar 18, 2019 at 10:14:48AM +0100, Sascha Hauer wrote:
> > barebox_arm_reset_vector() is a global function but we never provided a
> > prototype anywhere. The prototypes differ for the different boards, so
> > to provide a common prototype we must harmonize them.
> > 
> > void barebox_arm_reset_vector(uint32_t r0, uint32_t r1, uint32_t r2)
> > 
> > Should be suitable for all boards.
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> 
> [...]
> 
> > diff --git a/arch/arm/mach-imx/cpu_init.c b/arch/arm/mach-imx/cpu_init.c
> > index f0d009dfd2..471ef0cfd5 100644
> > --- a/arch/arm/mach-imx/cpu_init.c
> > +++ b/arch/arm/mach-imx/cpu_init.c
> > @@ -12,6 +12,7 @@
> >   * GNU General Public License for more details.
> >   */
> >  
> > +#include <common.h>
> 
> Was this intentional? The commit message doesn't say anything about it,
> and it is the only such change in the commit.

Yes, that is intentional. With the change of the prototype we need the
typedef for uint32_t which is undefined without previous inclusion of
linux/types.h (or common.h)

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-03-18 10:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-18  9:14 [PATCH 00/11] Fix -Wmissing-prototypes warnings Sascha Hauer
2019-03-18  9:14 ` [PATCH 01/11] ARM: semihosting: Fix function prototype Sascha Hauer
2019-03-18  9:14 ` [PATCH 02/11] treewide: Make locally used functions static Sascha Hauer
2019-03-18  9:14 ` [PATCH 03/11] treewide: Add missing includes Sascha Hauer
2019-03-18  9:14 ` [PATCH 04/11] ARM: i.MX: external-nand-boot: remove unused i.MX21 entry Sascha Hauer
2019-03-18  9:14 ` [PATCH 05/11] ARM: boards: Harmonize barebox_arm_reset_vector() prototype Sascha Hauer
2019-03-18 10:31   ` Roland Hieber
2019-03-18 10:41     ` Sascha Hauer [this message]
2019-03-18  9:14 ` [PATCH 06/11] ARM: sha256: Remove unused functions Sascha Hauer
2019-03-18  9:14 ` [PATCH 07/11] ARM: sha256: Remove unused header file Sascha Hauer
2019-03-18  9:14 ` [PATCH 08/11] ARM: PXA: Provide prototype for pxa_clear_reset_source() Sascha Hauer
2019-03-18  9:14 ` [PATCH 09/11] bus: mvebu-mbus: Add missing whitespace Sascha Hauer
2019-03-18  9:14 ` [PATCH 10/11] mfd: twl-core: Add missing prototype for twlcore_get() Sascha Hauer
2019-03-18  9:14 ` [PATCH 11/11] fs: squashfs: Remove unused function Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190318104107.w3brsm7vfxvjswlt@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox