From: Sascha Hauer <s.hauer@pengutronix.de>
To: Tomaz Solc <tomaz.solc@tablix.org>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: rpi: add board revision for Compute Module 3+
Date: Wed, 27 Mar 2019 08:44:49 +0100 [thread overview]
Message-ID: <20190327074449.nnvbk5wfbiax5f45@pengutronix.de> (raw)
In-Reply-To: <20190325143410.18249-1-tomaz.solc@tablix.org>
Hi Tomaz,
The patch itself looks good. Please resend with a Signed-off-by tag.
Sascha
On Mon, Mar 25, 2019 at 03:34:10PM +0100, Tomaz Solc wrote:
> ---
> arch/arm/boards/raspberry-pi/rpi-common.c | 2 ++
> arch/arm/mach-bcm283x/include/mach/mbox.h | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/arch/arm/boards/raspberry-pi/rpi-common.c b/arch/arm/boards/raspberry-pi/rpi-common.c
> index 60cea7f8e..bc877f853 100644
> --- a/arch/arm/boards/raspberry-pi/rpi-common.c
> +++ b/arch/arm/boards/raspberry-pi/rpi-common.c
> @@ -197,6 +197,8 @@ const struct rpi_model rpi_models_new_scheme[] = {
> RPI_MODEL(BCM2835_BOARD_REV_ZERO_W, "Zero W", rpi_b_plus_init),
> RPI_MODEL(BCM2837B0_BOARD_REV_3B_PLUS, "Model 3 B+", rpi_b_plus_init ),
> RPI_MODEL(BCM2837B0_BOARD_REV_3A_PLUS, "Nodel 3 A+", rpi_b_plus_init),
> + RPI_MODEL(0xf, "Unknown model", NULL),
> + RPI_MODEL(BCM2837B0_BOARD_REV_CM3_PLUS, "Compute Module 3+", NULL),
> };
>
> static int rpi_board_rev = 0;
> diff --git a/arch/arm/mach-bcm283x/include/mach/mbox.h b/arch/arm/mach-bcm283x/include/mach/mbox.h
> index e4f6cb675..6db961b80 100644
> --- a/arch/arm/mach-bcm283x/include/mach/mbox.h
> +++ b/arch/arm/mach-bcm283x/include/mach/mbox.h
> @@ -166,6 +166,7 @@ struct bcm2835_mbox_tag_hdr {
> #define BCM2835_BOARD_REV_ZERO_W 0x0c
> #define BCM2837B0_BOARD_REV_3B_PLUS 0x0d
> #define BCM2837B0_BOARD_REV_3A_PLUS 0x0e
> +#define BCM2837B0_BOARD_REV_CM3_PLUS 0x10
>
> struct bcm2835_mbox_tag_get_board_rev {
> struct bcm2835_mbox_tag_hdr tag_hdr;
> --
> 2.11.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-03-27 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 14:34 Tomaz Solc
2019-03-27 7:44 ` Sascha Hauer [this message]
2019-03-27 8:30 ` [PATCH v2] " Tomaz Solc
2019-03-27 8:43 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327074449.nnvbk5wfbiax5f45@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=tomaz.solc@tablix.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox