From: Sascha Hauer <s.hauer@pengutronix.de>
To: Teresa Remmet <t.remmet@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] common: bootchooser: Fix compile warning
Date: Wed, 10 Apr 2019 08:18:10 +0200 [thread overview]
Message-ID: <20190410061810.tzf7xkciop3wr3zr@pengutronix.de> (raw)
In-Reply-To: <1554729932-489-1-git-send-email-t.remmet@phytec.de>
On Mon, Apr 08, 2019 at 03:25:32PM +0200, Teresa Remmet wrote:
> Make bootchooser_get_target() static to prevent following warning:
>
> common/bootchooser.c:633:28: warning: no previous prototype for
> ‘bootchooser_get_target’ [-Wmissing-prototypes]
> struct bootchooser_target *bootchooser_get_target(struct bootchooser *bc)
>
> Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> ---
Already fixed with 27166fb0b1 ("treewide: Make locally used functions static")
Sascha
> common/bootchooser.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/bootchooser.c b/common/bootchooser.c
> index c47c734c9c7a..c08db03ebaa1 100644
> --- a/common/bootchooser.c
> +++ b/common/bootchooser.c
> @@ -630,7 +630,7 @@ void bootchooser_info(struct bootchooser *bc)
> *
> * Return: The next target
> */
> -struct bootchooser_target *bootchooser_get_target(struct bootchooser *bc)
> +static struct bootchooser_target *bootchooser_get_target(struct bootchooser *bc)
> {
> struct bootchooser_target *target;
>
> --
> 2.7.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-04-10 6:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 13:25 Teresa Remmet
2019-04-10 6:18 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410061810.tzf7xkciop3wr3zr@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=t.remmet@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox