mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] clk: socfpga: fix compiler warnings for Cyclone5
Date: Wed, 10 Apr 2019 08:22:50 +0200	[thread overview]
Message-ID: <20190410062250.5ipgpxho7a7lnkj2@pengutronix.de> (raw)
In-Reply-To: <20190408144932.29201-1-abbotti@mev.co.uk>

On Mon, Apr 08, 2019 at 03:49:32PM +0100, Ian Abbott wrote:
> When building for Cyclone5 SoCFPGA, the socfpga_a10_pll_init(),
> socfpga_a10_perith_init() and socfpga_a10_gate_init() functions are
> defined as dummy functions returning ERR_PTR(-ENOSYS).  They are defined
> with external linkage.  With '-Wmissing-prototypes' GCC warns about
> externally linked function definitions with no preceding prototype.
> Define them as 'static inline' to avoid the compiler warnings.
> 
> (Note: Arria10 uses non-dummy versions of these functions declared
> 'extern' but defined elsewhere.)
> 
> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
> ---
>  drivers/clk/socfpga/clk.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2019-04-10  6:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08 14:49 Ian Abbott
2019-04-10  6:22 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190410062250.5ipgpxho7a7lnkj2@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=abbotti@mev.co.uk \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox