mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] ARM: socfpga: Cyclone5: remove watchdog_disable()
@ 2019-04-10  9:37 Ian Abbott
  2019-04-23  8:34 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ian Abbott @ 2019-04-10  9:37 UTC (permalink / raw)
  To: barebox; +Cc: Ian Abbott

watchdog_disable() is left over from the original SoCFPGA commit and
nothing calls it.  Remove it to avoid a '-Wmissing-prototypes' warning
from the compiler.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
---
 arch/arm/mach-socfpga/cyclone5-reset-manager.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/arch/arm/mach-socfpga/cyclone5-reset-manager.c b/arch/arm/mach-socfpga/cyclone5-reset-manager.c
index 4bbe1a810..863580684 100644
--- a/arch/arm/mach-socfpga/cyclone5-reset-manager.c
+++ b/arch/arm/mach-socfpga/cyclone5-reset-manager.c
@@ -22,23 +22,6 @@
 #include <mach/cyclone5-regs.h>
 #include <mach/cyclone5-reset-manager.h>
 
-/* Disable the watchdog (toggle reset to watchdog) */
-void watchdog_disable(void)
-{
-	void __iomem *rm = (void *)CYCLONE5_RSTMGR_ADDRESS;
-	uint32_t val;
-
-	/* assert reset for watchdog */
-	val = readl(rm + RESET_MGR_PER_MOD_RESET_OFS);
-	val |= 1 << RSTMGR_PERMODRST_L4WD0_LSB;
-	writel(val, rm + RESET_MGR_PER_MOD_RESET_OFS);
-
-	/* deassert watchdog from reset (watchdog in not running state) */
-	val = readl(rm + RESET_MGR_PER_MOD_RESET_OFS);
-	val &= ~(1 << RSTMGR_PERMODRST_L4WD0_LSB);
-	writel(val, rm + RESET_MGR_PER_MOD_RESET_OFS);
-}
-
 /* Write the reset manager register to cause reset */
 static void __noreturn socfpga_restart_soc(struct restart_handler *rst)
 {
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: socfpga: Cyclone5: remove watchdog_disable()
  2019-04-10  9:37 [PATCH] ARM: socfpga: Cyclone5: remove watchdog_disable() Ian Abbott
@ 2019-04-23  8:34 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2019-04-23  8:34 UTC (permalink / raw)
  To: Ian Abbott; +Cc: barebox

On Wed, Apr 10, 2019 at 10:37:37AM +0100, Ian Abbott wrote:
> watchdog_disable() is left over from the original SoCFPGA commit and
> nothing calls it.  Remove it to avoid a '-Wmissing-prototypes' warning
> from the compiler.
> 
> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
> ---
>  arch/arm/mach-socfpga/cyclone5-reset-manager.c | 17 -----------------
>  1 file changed, 17 deletions(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-04-23  8:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-10  9:37 [PATCH] ARM: socfpga: Cyclone5: remove watchdog_disable() Ian Abbott
2019-04-23  8:34 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox