[PATCH] ARM: aarch64: do not use 32bit optimized find bit functions

[PATCH] ARM: aarch64: do not use 32bit optimized find bit functions

[Michael Tretter]

The optimized find bit functions are only implemented for 32 bit and are
not built on aarch64 systems. Therefore, for example bootchooser cannot
be build for aarch64.

Select the generic find_bit implementations on aarch64.

As the decision, if lib64 or lib32 is build or not, directly depends on
CPU_V8, the generic implementation also should be used if CPU_V8 is
selected.

Reported-by: Thomas Hämmerle <Thomas.Haemmerle@wolfvision.net>
Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 arch/arm/cpu/Kconfig          | 1 +
 arch/arm/include/asm/bitops.h | 8 ++++++++
 2 files changed, 9 insertions(+)

diff --git a/arch/arm/cpu/Kconfig b/arch/arm/cpu/Kconfig
index 2577103293..f8abbccfca 100644
--- a/arch/arm/cpu/Kconfig
+++ b/arch/arm/cpu/Kconfig
@@ -86,6 +86,7 @@ config CPU_V8
 	select CPU_64v8
 	select CPU_SUPPORTS_64BIT_KERNEL
 	select ARM_EXCEPTIONS
+	select GENERIC_FIND_NEXT_BIT
 
 config CPU_XSC3
         bool
diff --git a/arch/arm/include/asm/bitops.h b/arch/arm/include/asm/bitops.h
index 348a76b2c1..d8a4d9b667 100644
--- a/arch/arm/include/asm/bitops.h
+++ b/arch/arm/include/asm/bitops.h
@@ -82,6 +82,12 @@ static inline int test_bit(int nr, const void * addr)
 #define test_and_clear_bit(x, y)	__test_and_clear_bit(x, y)
 #define test_and_change_bit(x, y)	__test_and_change_bit(x, y)
 
+#ifdef CONFIG_CPU_V8
+
+#include <asm-generic/bitops/find.h>
+
+#else /* CONFIG_CPU_V8 */
+
 #ifndef __ARMEB__
 /*
  * These are the little endian definitions.
@@ -115,6 +121,8 @@ extern int _find_next_bit_be(const unsigned long *p, int size, int offset);
 
 #endif		/* __ARMEB__ */
 
+#endif /* CONFIG_CPU_V8 */
+
 #if defined (CONFIG_CPU_32) && defined(__LINUX_ARM_ARCH__) && (__LINUX_ARM_ARCH__ >= 5)
 static inline int constant_fls(int x)
 {
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] ARM: aarch64: do not use 32bit optimized find bit functions

[Sascha Hauer]

On Fri, May 03, 2019 at 05:53:39PM +0200, Michael Tretter wrote:
> The optimized find bit functions are only implemented for 32 bit and are
> not built on aarch64 systems. Therefore, for example bootchooser cannot
> be build for aarch64.
> 
> Select the generic find_bit implementations on aarch64.
> 
> As the decision, if lib64 or lib32 is build or not, directly depends on
> CPU_V8, the generic implementation also should be used if CPU_V8 is
> selected.
> 
> Reported-by: Thomas Hämmerle <Thomas.Haemmerle@wolfvision.net>
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
>  arch/arm/cpu/Kconfig          | 1 +
>  arch/arm/include/asm/bitops.h | 8 ++++++++
>  2 files changed, 9 insertions(+)

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox