mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] spi: Enable Freescale QSPI controller driver for VF610
@ 2019-05-13 23:59 Andrey Smirnov
  2019-05-14 11:32 ` Sascha Hauer
  0 siblings, 1 reply; 3+ messages in thread
From: Andrey Smirnov @ 2019-05-13 23:59 UTC (permalink / raw)
  To: barebox; +Cc: Andrey Smirnov

VF610 is supported by this driver, so modify its Kconfig entry to
reflect that.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
 drivers/spi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index d687105ea..2e57457dc 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -27,7 +27,7 @@ config DRIVER_SPI_ATMEL
 
 config DRIVER_SPI_FSL_QUADSPI
 	bool "Freescale QSPI controller"
-	depends on ARCH_IMX25 || ARCH_IMX31 || ARCH_IMX35 || ARCH_IMX50 || ARCH_IMX53 || ARCH_LAYERSCAPE
+	depends on ARCH_IMX25 || ARCH_IMX31 || ARCH_IMX35 || ARCH_IMX50 || ARCH_IMX53 || ARCH_LAYERSCAPE || ARCH_VF610
 	depends on SPI_MEM
 	help
 	  This enables support for the Quad SPI controller in master mode.
-- 
2.21.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] spi: Enable Freescale QSPI controller driver for VF610
  2019-05-13 23:59 [PATCH] spi: Enable Freescale QSPI controller driver for VF610 Andrey Smirnov
@ 2019-05-14 11:32 ` Sascha Hauer
  2019-05-14 13:30   ` Cory Tusar
  0 siblings, 1 reply; 3+ messages in thread
From: Sascha Hauer @ 2019-05-14 11:32 UTC (permalink / raw)
  To: Andrey Smirnov; +Cc: barebox

On Mon, May 13, 2019 at 04:59:44PM -0700, Andrey Smirnov wrote:
> VF610 is supported by this driver, so modify its Kconfig entry to
> reflect that.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  drivers/spi/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index d687105ea..2e57457dc 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -27,7 +27,7 @@ config DRIVER_SPI_ATMEL
>  
>  config DRIVER_SPI_FSL_QUADSPI
>  	bool "Freescale QSPI controller"
> -	depends on ARCH_IMX25 || ARCH_IMX31 || ARCH_IMX35 || ARCH_IMX50 || ARCH_IMX53 || ARCH_LAYERSCAPE
> +	depends on ARCH_IMX25 || ARCH_IMX31 || ARCH_IMX35 || ARCH_IMX50 || ARCH_IMX53 || ARCH_LAYERSCAPE || ARCH_VF610

Not your fault, but this list is bogus. None of the i.MX SoCs actually
has this hardware and the ones that have it are not in the list. We
should rather remove this line entirely.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] spi: Enable Freescale QSPI controller driver for VF610
  2019-05-14 11:32 ` Sascha Hauer
@ 2019-05-14 13:30   ` Cory Tusar
  0 siblings, 0 replies; 3+ messages in thread
From: Cory Tusar @ 2019-05-14 13:30 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: Andrey Smirnov, barebox

On Tue, May 14, 2019 at 01:32:26PM +0200, Sascha Hauer wrote:
> On Mon, May 13, 2019 at 04:59:44PM -0700, Andrey Smirnov wrote:
> > VF610 is supported by this driver, so modify its Kconfig entry to
> > reflect that.
> >
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > ---
> >  drivers/spi/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> > index d687105ea..2e57457dc 100644
> > --- a/drivers/spi/Kconfig
> > +++ b/drivers/spi/Kconfig
> > @@ -27,7 +27,7 @@ config DRIVER_SPI_ATMEL
> >
> >  config DRIVER_SPI_FSL_QUADSPI
> >  bool "Freescale QSPI controller"
> > -depends on ARCH_IMX25 || ARCH_IMX31 || ARCH_IMX35 || ARCH_IMX50 || ARCH_IMX53 || ARCH_LAYERSCAPE
> > +depends on ARCH_IMX25 || ARCH_IMX31 || ARCH_IMX35 || ARCH_IMX50 || ARCH_IMX53 || ARCH_LAYERSCAPE || ARCH_VF610
>
> Not your fault, but this list is bogus. None of the i.MX SoCs actually
> has this hardware and the ones that have it are not in the list. We
> should rather remove this line entirely.

Should be ARCH_MX6SX || ARCH_MX7 || ARCH_VF610 at the very least, no?
I believe some of the the Layerscape SoCs use the same / very similar
hardware block, but I don't know which ones off the top of my head.

-Cory


--
Cory Tusar
Senior Software Engineer
Zodiac Inflight Innovations
2929 E Imperial Hwy, Suite 170
Brea, CA 92821
(714) 203-0519

www.safran-aerosystems.com

________________________________

This email and any files transmitted with it are confidential & proprietary to Zodiac Inflight Innovations. This information is intended solely for the use of the individual or entity to which it is addressed. Access or transmittal of the information contained in this e-mail, in full or in part, to any other organization or persons is not authorized.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-14 13:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-13 23:59 [PATCH] spi: Enable Freescale QSPI controller driver for VF610 Andrey Smirnov
2019-05-14 11:32 ` Sascha Hauer
2019-05-14 13:30   ` Cory Tusar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox