From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: distclean removing LICENSES .gitignores
Date: Wed, 15 May 2019 09:44:57 +0200 [thread overview]
Message-ID: <20190515074457.mh77wvyugj6efscl@pengutronix.de> (raw)
In-Reply-To: <bafb7600-4351-2c80-d78f-35d59ae559ba@pengutronix.de>
On Mon, May 13, 2019 at 05:05:39PM +0200, Ahmad Fatoum wrote:
> Hello Geordan,
>
> On 13/5/19 00:17, Geordan Neukum wrote:
> > When on the master branch, I noticed that running a "make distclean"
> > will remove:
> >
> > - LICENSES/exceptions/.gitignore
> >
> > - LICENSES/other/.gitignore
> >
> >
> > It looks like this is due to matching the pattern '-o size 0' in the
> > top-level barebox makefile under the distclean target.
> >
> > Is this the desired behavior?
>
> Nope, this behavior isn't desired. I added the files, to have git
> index the directories. IIRC, otherwise kernel checkpatch.pl laments their
> absence. Maybe we should add a comment describing the purpose and then
> these files aren't totally empty?
barebox has its own checkpatch script which doesn't have the problem yet
as it's copied from the kernel when there was no SPDX check, so we need
an updated checkpatch to even get this problem ;)
Then in the Kernel "other" was renamed to "deprecated", so with the
current spdxcheck.py we get an exception in the kernel aswell. There
were two patches sent for this on LKML:
https://lkml.org/lkml/2019/5/11/158
But honestly I don't know the intention why spdxcheck expects certain
directories to exist instead of looking which directories are actually
there.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-05-15 7:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-12 22:17 Geordan Neukum
2019-05-13 15:05 ` Ahmad Fatoum
2019-05-14 2:19 ` [PATCH] LICENSES: modify .gitignore files to be nonempty Geordan Neukum
2019-05-14 7:28 ` Ian Abbott
2019-05-14 8:28 ` Ahmad Fatoum
2019-05-14 12:51 ` Ian Abbott
2019-05-15 0:45 ` [PATCH v2] " Geordan Neukum
2019-05-15 8:54 ` Ahmad Fatoum
2019-05-15 0:56 ` [PATCH] " Geordan Neukum
2019-05-14 8:35 ` Uwe Kleine-König
2019-05-14 10:37 ` [PATCH v2] " Geordan Neukum
2019-05-14 11:00 ` Ahmad Fatoum
2019-05-15 7:44 ` Sascha Hauer [this message]
2019-05-16 3:53 ` distclean removing LICENSES .gitignores Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515074457.mh77wvyugj6efscl@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox