From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] serdev: Do not call .receive_buf() callback recursively
Date: Wed, 15 May 2019 10:10:20 +0200 [thread overview]
Message-ID: <20190515081020.mv7v7cjqulp5ra3t@pengutronix.de> (raw)
In-Reply-To: <20190513235908.18693-1-andrew.smirnov@gmail.com>
On Mon, May 13, 2019 at 04:59:08PM -0700, Andrey Smirnov wrote:
> Code implementing .receive_buf() callback can potentially call
> serdev_device_write(), which will call serdev_device_poller(). We need
> to make sure that such a call is a no-op in order to prevent
> corrupting shared data buffer as well as breaking .receive_buf
> callback that most likely does not expect that to happen.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> common/serdev.c | 6 ++++++
> include/serdev.h | 2 ++
> 2 files changed, 8 insertions(+)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-05-15 8:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 23:59 Andrey Smirnov
2019-05-14 1:49 ` Cory Tusar
2019-05-15 8:10 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515081020.mv7v7cjqulp5ra3t@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox