From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQozX-0004sT-62 for barebox@lists.infradead.org; Wed, 15 May 2019 08:10:24 +0000 Date: Wed, 15 May 2019 10:10:20 +0200 From: Sascha Hauer Message-ID: <20190515081020.mv7v7cjqulp5ra3t@pengutronix.de> References: <20190513235908.18693-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190513235908.18693-1-andrew.smirnov@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] serdev: Do not call .receive_buf() callback recursively To: Andrey Smirnov Cc: barebox@lists.infradead.org On Mon, May 13, 2019 at 04:59:08PM -0700, Andrey Smirnov wrote: > Code implementing .receive_buf() callback can potentially call > serdev_device_write(), which will call serdev_device_poller(). We need > to make sure that such a call is a no-op in order to prevent > corrupting shared data buffer as well as breaking .receive_buf > callback that most likely does not expect that to happen. > > Signed-off-by: Andrey Smirnov > --- > common/serdev.c | 6 ++++++ > include/serdev.h | 2 ++ > 2 files changed, 8 insertions(+) Applied, thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox