From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH] commands: spi: fix NULL pointer dereference
Date: Thu, 16 May 2019 11:18:39 +0200 [thread overview]
Message-ID: <20190516091839.8504-1-s.trumtrar@pengutronix.de> (raw)
The renaming of "master" to "controller" done in
812a9ddcdf211302a050cf8f61f7af577bc29a23
spi: Generalize SPI "master" to "controller"
breaks the spi command, because the spi.master pointer is not assigned.
The pointer is kept for backwards compatability.
Assign it, so that spi drivers that are still using "spi->master" can be
used.
Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
commands/spi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/commands/spi.c b/commands/spi.c
index 55a0e255af17..d35aa1cd81c9 100644
--- a/commands/spi.c
+++ b/commands/spi.c
@@ -67,6 +67,7 @@ static int do_spi(int argc, char *argv[])
printf("spi bus %d not found\n", bus);
return -ENODEV;
}
+ spi.master = spi.controller;
if (spi.chip_select >= spi.controller->num_chipselect) {
printf("spi chip select (%d) >= controller num chipselect (%d)\n",
--
2.20.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2019-05-16 9:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 9:18 Steffen Trumtrar [this message]
2019-05-17 7:34 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190516091839.8504-1-s.trumtrar@pengutronix.de \
--to=s.trumtrar@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox