From: Sascha Hauer <s.hauer@pengutronix.de>
To: Michael Grzeschik <m.grzeschik@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] gpio: add driver for PCF857x, PCA{85, 96}7x, and MAX732[89] I2C GPIO expanders
Date: Tue, 21 May 2019 11:29:09 +0200 [thread overview]
Message-ID: <20190521092909.rxl3wp4ozpzgekfd@pengutronix.de> (raw)
In-Reply-To: <20190517233606.28573-1-m.grzeschik@pengutronix.de>
On Sat, May 18, 2019 at 01:36:06AM +0200, Michael Grzeschik wrote:
> +static int pcf857x_probe(struct device_d *dev)
> +{
> + struct i2c_client *client = to_i2c_client(dev);
> + struct pcf857x_platform_data *pdata = dev->platform_data;
> + struct device_node *np = dev->device_node;
> + struct pcf857x *gpio;
> + unsigned long driver_data;
> + unsigned int n_latch = 0;
> + int ret;
> +
> + if (IS_ENABLED(CONFIG_OF) && np)
> + of_property_read_u32(np, "lines-initial-states", &n_latch);
> + else if (pdata)
> + n_latch = pdata->n_latch;
> +
> + /* Allocate, initialize, and register this gpio_chip. */
> + gpio = xzalloc(sizeof(*gpio));
> + if (!gpio)
> + return -ENOMEM;
xzalloc never returns NULL.
> + ret = gpiochip_add(&gpio->chip);
> + if (ret)
> + return ret;
> +
> + /* Let platform code set up the GPIOs and their users.
> + * Now is the first time anyone could use them.
> + */
> + if (pdata && pdata->setup) {
> + ret = pdata->setup(client,
> + gpio->chip.base, gpio->chip.ngpio,
> + pdata->context);
> + if (ret < 0)
> + dev_warn(&client->dev, "setup failed, %d\n", ret);
> + }
I don't think we want to have that pdata->setup() support.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-05-21 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 23:36 Michael Grzeschik
2019-05-18 7:21 ` Sam Ravnborg
2019-05-21 9:29 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521092909.rxl3wp4ozpzgekfd@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=m.grzeschik@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox