From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH 1/2] libfile: Simplify read_full()
Date: Mon, 27 May 2019 22:58:52 -0700 [thread overview]
Message-ID: <20190528055853.4863-1-andrew.smirnov@gmail.com> (raw)
We can figure out the amount of written data by substracting 'insize'
from 'size' so there is no need to keep a separate counter for that.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
lib/libfile.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/lib/libfile.c b/lib/libfile.c
index eb12d158d..814cd9c2c 100644
--- a/lib/libfile.c
+++ b/lib/libfile.c
@@ -80,20 +80,18 @@ int read_full(int fd, void *buf, size_t size)
{
size_t insize = size;
int now;
- int total = 0;
while (size) {
now = read(fd, buf, size);
if (now == 0)
- return total;
+ break;
if (now < 0)
return now;
- total += now;
size -= now;
buf += now;
}
- return insize;
+ return insize - size;
}
EXPORT_SYMBOL(read_full);
--
2.21.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2019-05-28 5:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 5:58 Andrey Smirnov [this message]
2019-05-28 5:58 ` [PATCH 2/2] libfile: Do not return 0 from write_full() Andrey Smirnov
2019-05-28 8:17 ` [PATCH 1/2] libfile: Simplify read_full() Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528055853.4863-1-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox