From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVYt2-00020M-MQ for barebox@lists.infradead.org; Tue, 28 May 2019 09:59:18 +0000 Date: Tue, 28 May 2019 11:59:15 +0200 From: Sascha Hauer Message-ID: <20190528095914.oq4f7t3lfuzbrk7s@pengutronix.de> References: <20190527072557.31805-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190527072557.31805-1-a.fatoum@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] scripts: kwboot: fix comparison with out-of-range constant To: Ahmad Fatoum Cc: barebox@lists.infradead.org On Mon, May 27, 2019 at 09:25:57AM +0200, Ahmad Fatoum wrote: > clang detects that system char signedness will affect program runtime: > scripts/kwboot.c:395:10: warning: result of comparison of constant 255 > with expression of type 'char' is always true > [-Wtautological-constant-out-of-range-compare] > if (*p != 0xff) > ~~ ^ ~~~~ > > Fix this by using uint8_t where appropriate. > > Signed-off-by: Ahmad Fatoum > --- > scripts/kwboot.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Applied, thanks Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox