Re: [PATCH] ARM: panic with a message when relocation type is unknown

[Sam Ravnborg <sam@ravnborg.org>]

Hi Ahmad.

On Fri, May 31, 2019 at 11:02:23AM +0200, Ahmad Fatoum wrote:
> Currently such failures result in a
> 
> 	>00000000 00000000
> 
> 	### ERROR ### Please RESET the board ###
> 
> With this patch this now becomes
> 
> 	>00000000 00000000
> 	Unknown relocation type
> 	### ERROR ### Please RESET the board ###
> 
> which improves user experience a little bit.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  arch/arm/cpu/common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/cpu/common.c b/arch/arm/cpu/common.c
> index 821cafbf26c2..3668c5977ca9 100644
> --- a/arch/arm/cpu/common.c
> +++ b/arch/arm/cpu/common.c
> @@ -78,7 +78,7 @@ void relocate_to_current_adr(void)
>  			putc_ll(' ');
>  			puthex_ll(rel->r_addend);
>  			putc_ll('\n');
> -			panic("");
> +			panic("Unknown relocation type");
>  		}
>  
>  		dstart += sizeof(*rel);
> @@ -108,7 +108,7 @@ void relocate_to_current_adr(void)
>  			putc_ll(' ');
>  			puthex_ll(rel->r_offset);
>  			putc_ll('\n');
> -			panic("");
> +			panic("Unknown relocation type");

If you added just a little bit more context then grepping the source
for the error message would only result in one hit.

Like:
"Unknown relocation type (addend)"
"Unknown relocation type (offset)"

Or something like that.

	Sam

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox