From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/7] reset_source: add new Brownout reset (BOR) source
Date: Tue, 4 Jun 2019 10:11:39 +0200 [thread overview]
Message-ID: <20190604081139.kb2ond6ochfgosrg@pengutronix.de> (raw)
In-Reply-To: <20190603190559.16715-2-a.fatoum@pengutronix.de>
On Mon, Jun 03, 2019 at 09:05:54PM +0200, Ahmad Fatoum wrote:
> The STM32MP1 can report brown out as reason for a reset,
> which doesn't fit into existing reasons. Thus add a new
> one to the enumeration.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> common/reset_source.c | 1 +
> include/reset_source.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/common/reset_source.c b/common/reset_source.c
> index 338d7b9acb30..0489724f3e7f 100644
> --- a/common/reset_source.c
> +++ b/common/reset_source.c
> @@ -28,6 +28,7 @@ static const char * const reset_src_names[] = {
> [RESET_JTAG] = "JTAG",
> [RESET_THERM] = "THERM",
> [RESET_EXT] = "EXT",
> + [RESET_BOR] = "BOR",
> };
>
> static enum reset_src_type reset_source;
> diff --git a/include/reset_source.h b/include/reset_source.h
> index 86e415abcf84..c124278ec674 100644
> --- a/include/reset_source.h
> +++ b/include/reset_source.h
> @@ -22,6 +22,7 @@ enum reset_src_type {
> RESET_JTAG, /* JTAG reset */
> RESET_THERM, /* SoC shut down because of overtemperature */
> RESET_EXT, /* External reset through device pin */
> + RESET_BOR, /* Brownout Reset */
Reading "BOR" as "Brown Out Reset" is not very obvious. Maybe better use
RESET_BROWNOUT and "BROWNOUT". That shouldn't be too long to read and
write.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-06-04 8:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 19:05 [PATCH 1/7] ARM: stm32mp1: rename to stm32mp Ahmad Fatoum
2019-06-03 19:05 ` [PATCH 2/7] reset_source: add new Brownout reset (BOR) source Ahmad Fatoum
2019-06-04 8:11 ` Sascha Hauer [this message]
2019-06-04 8:31 ` Ahmad Fatoum
2019-06-03 19:05 ` [PATCH 3/7] watchdog: add stm32 watchdog and reset driver Ahmad Fatoum
2019-06-04 8:24 ` Sascha Hauer
2019-06-04 8:51 ` Ahmad Fatoum
2019-06-04 11:07 ` Sascha Hauer
2019-06-04 17:23 ` Roland Hieber
2019-06-03 19:05 ` [PATCH 4/7] ARM: stm32mp1: enable watchdog in oftree and defconfig Ahmad Fatoum
2019-06-03 19:34 ` Sam Ravnborg
2019-06-03 19:46 ` Ahmad Fatoum
2019-06-03 19:05 ` [PATCH 5/7] ARM: stm32mp: stm32mp157c-dk2: configure debug_ll UART Ahmad Fatoum
2019-06-03 19:05 ` [PATCH 6/7] ARM: stm32mp: stm32mp157c-dk2: compress the DTB Ahmad Fatoum
2019-06-03 19:05 ` [PATCH 7/7] ARM: stm32mp: add entry point, not point.pblb to pblb-y Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604081139.kb2ond6ochfgosrg@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox