mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] serial_ns16550: readd support for mvebu armada 38x
@ 2019-06-03 20:12 Uwe Kleine-König
  2019-06-04  8:27 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2019-06-03 20:12 UTC (permalink / raw)
  To: barebox

The armada 38x device tree traditionally used "snps,dw-apb-uart" as
compatible for the internal UARTs. This was changed in Linux by commit
b7639b0b15dd ("serial: 8250_dw: Limit dw8250_tx_wait_empty quirk to
armada-38x devices") which was imported into barebox in e4067b75fb6c
("dts: update to v4.18-rc1") to "marvell,armada-38x-uart".

Teach the driver about the new compatible to make the console work
again.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/serial/serial_ns16550.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/serial/serial_ns16550.c b/drivers/serial/serial_ns16550.c
index ccd082e495c3..4c84d27bdc1b 100644
--- a/drivers/serial/serial_ns16550.c
+++ b/drivers/serial/serial_ns16550.c
@@ -525,6 +525,9 @@ static struct of_device_id ns16550_serial_dt_ids[] = {
 	}, {
 		.compatible = "snps,dw-apb-uart",
 		.data = &ns16550_drvdata,
+	}, {
+		.compatible = "marvell,armada-38x-uart",
+		.data = &ns16550_drvdata,
 	},
 #if IS_ENABLED(CONFIG_ARCH_OMAP)
 	{
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] serial_ns16550: readd support for mvebu armada 38x
  2019-06-03 20:12 [PATCH] serial_ns16550: readd support for mvebu armada 38x Uwe Kleine-König
@ 2019-06-04  8:27 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2019-06-04  8:27 UTC (permalink / raw)
  To: Uwe Kleine-König; +Cc: barebox

On Mon, Jun 03, 2019 at 10:12:43PM +0200, Uwe Kleine-König wrote:
> The armada 38x device tree traditionally used "snps,dw-apb-uart" as
> compatible for the internal UARTs. This was changed in Linux by commit
> b7639b0b15dd ("serial: 8250_dw: Limit dw8250_tx_wait_empty quirk to
> armada-38x devices") which was imported into barebox in e4067b75fb6c
> ("dts: update to v4.18-rc1") to "marvell,armada-38x-uart".
> 
> Teach the driver about the new compatible to make the console work
> again.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/serial/serial_ns16550.c | 3 +++
>  1 file changed, 3 insertions(+)

Applied, thanks

Sascha

> 
> diff --git a/drivers/serial/serial_ns16550.c b/drivers/serial/serial_ns16550.c
> index ccd082e495c3..4c84d27bdc1b 100644
> --- a/drivers/serial/serial_ns16550.c
> +++ b/drivers/serial/serial_ns16550.c
> @@ -525,6 +525,9 @@ static struct of_device_id ns16550_serial_dt_ids[] = {
>  	}, {
>  		.compatible = "snps,dw-apb-uart",
>  		.data = &ns16550_drvdata,
> +	}, {
> +		.compatible = "marvell,armada-38x-uart",
> +		.data = &ns16550_drvdata,
>  	},
>  #if IS_ENABLED(CONFIG_ARCH_OMAP)
>  	{
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-04  8:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-03 20:12 [PATCH] serial_ns16550: readd support for mvebu armada 38x Uwe Kleine-König
2019-06-04  8:27 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox