From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: rdu2: Initialize DEBUG_LL in entry function
Date: Tue, 4 Jun 2019 10:28:12 +0200 [thread overview]
Message-ID: <20190604082812.qnn5hxv24pbq55pq@pengutronix.de> (raw)
In-Reply-To: <20190603192857.28852-1-andrew.smirnov@gmail.com>
On Mon, Jun 03, 2019 at 12:28:57PM -0700, Andrey Smirnov wrote:
> When bootstrapping Barebox via JTAG rdu2_sram_setup() won't be
> executed resulting in non functional DEBUG_LL API. Move low-level UART
> initialization code to be a part of start_imx6_zii_rdu2() to avoid
> that problem.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> arch/arm/boards/zii-imx6q-rdu2/lowlevel.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/arch/arm/boards/zii-imx6q-rdu2/lowlevel.c b/arch/arm/boards/zii-imx6q-rdu2/lowlevel.c
> index a5ac6f64c..9672a69bf 100644
> --- a/arch/arm/boards/zii-imx6q-rdu2/lowlevel.c
> +++ b/arch/arm/boards/zii-imx6q-rdu2/lowlevel.c
> @@ -271,11 +271,6 @@ static noinline void rdu2_sram_setup(void)
> enum bootsource bootsrc;
> int instance;
>
> - imx6_ungate_all_peripherals();
> -
> - if (IS_ENABLED(CONFIG_DEBUG_LL))
> - setup_uart();
> -
> arm_setup_stack(0x00920000 - 8);
> relocate_to_current_adr();
> setup_c();
> @@ -296,6 +291,11 @@ ENTRY_FUNCTION(start_imx6_zii_rdu2, r0, r1, r2)
> {
> imx6_cpu_lowlevel_init();
>
> + imx6_ungate_all_peripherals();
> +
> + if (IS_ENABLED(CONFIG_DEBUG_LL))
> + setup_uart();
> +
> /*
> * When still running in SRAM, we need to setup the DRAM now and load
> * the remaining image.
> --
> 2.21.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-06-04 8:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 19:28 Andrey Smirnov
2019-06-04 8:28 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604082812.qnn5hxv24pbq55pq@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox