From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hY4nm-0007uj-Mi for barebox@lists.infradead.org; Tue, 04 Jun 2019 08:28:19 +0000 Date: Tue, 4 Jun 2019 10:28:12 +0200 From: Sascha Hauer Message-ID: <20190604082812.qnn5hxv24pbq55pq@pengutronix.de> References: <20190603192857.28852-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190603192857.28852-1-andrew.smirnov@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] ARM: rdu2: Initialize DEBUG_LL in entry function To: Andrey Smirnov Cc: barebox@lists.infradead.org On Mon, Jun 03, 2019 at 12:28:57PM -0700, Andrey Smirnov wrote: > When bootstrapping Barebox via JTAG rdu2_sram_setup() won't be > executed resulting in non functional DEBUG_LL API. Move low-level UART > initialization code to be a part of start_imx6_zii_rdu2() to avoid > that problem. > > Signed-off-by: Andrey Smirnov > --- > arch/arm/boards/zii-imx6q-rdu2/lowlevel.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Applied, thanks Sascha > > diff --git a/arch/arm/boards/zii-imx6q-rdu2/lowlevel.c b/arch/arm/boards/zii-imx6q-rdu2/lowlevel.c > index a5ac6f64c..9672a69bf 100644 > --- a/arch/arm/boards/zii-imx6q-rdu2/lowlevel.c > +++ b/arch/arm/boards/zii-imx6q-rdu2/lowlevel.c > @@ -271,11 +271,6 @@ static noinline void rdu2_sram_setup(void) > enum bootsource bootsrc; > int instance; > > - imx6_ungate_all_peripherals(); > - > - if (IS_ENABLED(CONFIG_DEBUG_LL)) > - setup_uart(); > - > arm_setup_stack(0x00920000 - 8); > relocate_to_current_adr(); > setup_c(); > @@ -296,6 +291,11 @@ ENTRY_FUNCTION(start_imx6_zii_rdu2, r0, r1, r2) > { > imx6_cpu_lowlevel_init(); > > + imx6_ungate_all_peripherals(); > + > + if (IS_ENABLED(CONFIG_DEBUG_LL)) > + setup_uart(); > + > /* > * When still running in SRAM, we need to setup the DRAM now and load > * the remaining image. > -- > 2.21.0 > > > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox