From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hYant-0003bk-Pf for barebox@lists.infradead.org; Wed, 05 Jun 2019 18:38:31 +0000 Received: by mail-lj1-x243.google.com with SMTP id s21so13455090lji.8 for ; Wed, 05 Jun 2019 11:38:27 -0700 (PDT) Date: Wed, 5 Jun 2019 21:38:17 +0300 From: Peter Mamonov Message-ID: <20190605183817.w2vmyumiwo2tkszf@chr> References: <20190604105552.20619-1-pmamonov@gmail.com> <20190604124457.25u3p7mgfvxrbqjh@pengutronix.de> <20190604164311.z5zo4qrfqbt5zalf@localhost.localdomain> <20190605051703.gg6q43p5smhxzci4@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190605051703.gg6q43p5smhxzci4@pengutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] MIPS: use anonymous labels in ENTRY_FUNCTION_END and STOP_WITH_DEBUG_EVENT macros To: Oleksij Rempel Cc: barebox@lists.infradead.org On Wed, Jun 05, 2019 at 07:17:03AM +0200, Oleksij Rempel wrote: > On Tue, Jun 04, 2019 at 07:43:12PM +0300, Peter Mamonov wrote: > > Hi, Oleksij, > > > > On Tue, Jun 04, 2019 at 02:44:57PM +0200, Oleksij Rempel wrote: > > > On Tue, Jun 04, 2019 at 01:55:52PM +0300, Peter Mamonov wrote: > > > > Use of global labels of the same name inside ENTRY_FUNCTION_END and > > > > STOP_WITH_DEBUG_EVENT prevents simultaneous use of both macros. It also > > > > prevents multiple use of one of them. > > > > > > Reviewed-by: Oleksij Rempel > > > > > > @Peter, Do you use STOP_WITH_DEBUG_EVENT for something? > > > > Actually no. I hit this problem when tried to use ENTRY_FUNCTION_END twice to > > choose relevant DTB depending on some conditions. > > was you able to implement it? Yes, something like this: beq t0, zero, use_other_dtb nop ENTRY_FUNCTION_END(BOARD_PBL_START, some_dtb) use_other_dtb: ENTRY_FUNCTION_END(BOARD_PBL_START, other_dtb) Regards, Peter > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox