From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC 3/4] WIP: make it work on litex
Date: Fri, 7 Jun 2019 09:11:24 +0200 [thread overview]
Message-ID: <20190607071124.sozhmv2uoquycd4q@pengutronix.de> (raw)
In-Reply-To: <20190602073101.21352-4-antonynpavlov@gmail.com>
On Sun, Jun 02, 2019 at 10:31:00AM +0300, Antony Pavlov wrote:
> * litex platform does not use ns16550 at all
> so debug_ll_ns16550_init should be eliminated;
>
> * there is no IH_ARCH_RISCV definition in include/image.h
> at the moment, so the error stops compiling:
> common/bootm.c: In function 'bootm_open_os_uimage':
> common/bootm.c:491:34: error: 'IH_ARCH' undeclared (first use in this
> function)
> if (data->os->header.ih_arch != IH_ARCH) {
> ^~~~~~~
U-Boot has IH_ARCH_RISCV already, you can copy it there.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> arch/riscv/boot/start.S | 2 --
> common/bootm.c | 2 ++
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/boot/start.S b/arch/riscv/boot/start.S
> index d1dbe48b7b..fab23e926f 100644
> --- a/arch/riscv/boot/start.S
> +++ b/arch/riscv/boot/start.S
> @@ -28,8 +28,6 @@
>
> .globl _start
> _start:
> - debug_ll_ns16550_init
> -
This should be done by board code.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-06-07 7:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-02 7:30 [RFC 0/4] riscv: add initial LiteX SoC support Antony Pavlov
2019-06-02 7:30 ` [RFC 1/4] " Antony Pavlov
2019-06-02 7:30 ` [RFC 2/4] serial: add litex UART driver Antony Pavlov
2019-06-03 5:10 ` Ahmad Fatoum
2019-06-03 5:13 ` Ahmad Fatoum
2019-06-02 7:31 ` [RFC 3/4] WIP: make it work on litex Antony Pavlov
2019-06-07 7:11 ` Sascha Hauer [this message]
2019-06-02 7:31 ` [RFC 4/4] riscv: add litex_defconfig Antony Pavlov
2019-06-02 9:08 ` [RFC 0/4] riscv: add initial LiteX SoC support Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190607071124.sozhmv2uoquycd4q@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox