From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org,
"ore@pengutronix.de" <ore@pengutronix.de>,
rcz@pengutronix.de
Subject: Re: [PATCH v3 2/3] add CONFIG_PBL_BREAK option
Date: Tue, 11 Jun 2019 10:22:56 +0200 [thread overview]
Message-ID: <20190611082256.t7jzzaia3hlv7uia@pengutronix.de> (raw)
In-Reply-To: <2b8e26bf-950a-b1ca-2310-83a7c306d678@pengutronix.de>
On Sun, Jun 09, 2019 at 11:36:35PM +0200, Ahmad Fatoum wrote:
> Hello Oleksij,
>
> On 7/6/19 09:06, Rouven Czerwinski wrote:
> > From: Oleksij Rempel <linux@rempel-privat.de>
> >
> > With this option barebox will be build with breakpoint instruction
> > in early pbl stage and on main barebox entry. Otherwise two nop
> > instructions are generated which allow binary patching of existing
> > barebox binaries.
>
> At least arm-linux-gnueabihf-gcc (Debian 8.3.0-2) does some funny
> reordering with the result that the barebox header may no longer be
> at the very start of the image.
> This results e.g. in bootm not working for stm32 bareboxes, because
> file_detect_type no longer detects them as valid barebox ARM images.
>
> Steps to reproduce with current next:
>
> $ make stm32mp1_defconfig
> $ make
> $ xxd -l64 -g1 images/start_stm32mp157c_dk2.pblb
> 00000000: 04 46 0d 46 16 46 00 00 01 90 8f e2 19 ff 2f e1 .F.F.F......../.
> 00000010: 00 f0 22 f8 fe e7 fe e7 fe e7 fe e7 fe e7 fe e7 ..".............
> 00000020: fe e7 fe e7 fe e7 fe e7 62 61 72 65 62 6f 78 00 ........barebox.
> 00000030: 00 00 00 00 00 00 00 00 55 55 55 55 55 55 55 55 ........UUUUUUUU
>
> Note how the new 8 bytes are not after the __barebox_arm_head as they should.
> This leads to the barebox string being shifted from the
> ARM_HEAD_MAGICWORD_OFFSET, where it's expected.
>
> Could you take a look?
Yes, it doesn't work like this properly. I dropped 2/3 and 3/3 for now.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-06-11 8:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 7:06 [PATCH v3 1/3] remove CONFIG_DEBUG_INFO Rouven Czerwinski
2019-06-07 7:06 ` [PATCH v3 2/3] add CONFIG_PBL_BREAK option Rouven Czerwinski
2019-06-09 21:36 ` Ahmad Fatoum
2019-06-11 8:22 ` Sascha Hauer [this message]
2019-06-11 8:20 ` Sascha Hauer
2019-06-07 7:07 ` [PATCH v3 3/3] add gdb helper scripts to load barebox symbols Rouven Czerwinski
2019-06-07 7:27 ` [PATCH v3 1/3] remove CONFIG_DEBUG_INFO Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611082256.t7jzzaia3hlv7uia@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=ore@pengutronix.de \
--cc=rcz@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox