mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: barebox@lists.infradead.org
Subject: Re: Environment variables set by /env/bin/init disappear when script exits
Date: Wed, 12 Jun 2019 08:32:42 +0200	[thread overview]
Message-ID: <20190612063242.5lqb6nfattoghtdc@pengutronix.de> (raw)
In-Reply-To: <2ed1eda2-04b8-0ddc-0be0-793aae74f57d@mev.co.uk>

Hi Ian,

On Tue, Jun 11, 2019 at 04:21:06PM +0100, Ian Abbott wrote:
> On 11/06/2019 15:52, Ian Abbott wrote:
> > Since commit 90df2a955e3c ("defaultenv: Convert init script to C"), if
> > the legacy /env/bin/init script is still being used, any environment
> > variables that were set in the script (such as the PS1 prompt) disappear
> > when the script exits.  I guess it is because the script is now run
> > directly by run_command(initfile) (initfile is "/env/bin/init") rather
> > than by run_command("source /env/bin/init").
> 
> This seems easy to fix in "common/startup.c", assuming it is indeed a bug.
> Which of the following fixes would be preferable?

Indeed this behaviour was not intended and should be fixed.

> 
> 1. Call run_command with a string literal:
> 
>     run_command("source /env/bin/init");

I'd probably do something like this:

#define INITFILE "/env/bin/init"

	run_command("source " INITFILE);

But I might decide differently if you ask me tomorrow, so do whatever
looks best to you ;)

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2019-06-12  6:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-11 14:52 Ian Abbott
2019-06-11 15:21 ` Ian Abbott
2019-06-12  6:32   ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190612063242.5lqb6nfattoghtdc@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=abbotti@mev.co.uk \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox