From: Sascha Hauer <s.hauer@pengutronix.de>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] kbuild: do not drop -I without parameter
Date: Thu, 13 Jun 2019 08:25:23 +0200 [thread overview]
Message-ID: <20190613062523.hz5xckmfyjl4mm4b@pengutronix.de> (raw)
In-Reply-To: <20190611101635.22422-1-yamada.masahiro@socionext.com>
On Tue, Jun 11, 2019 at 07:16:35PM +0900, Masahiro Yamada wrote:
> Linux commit 48f6e3cf5bc6dd0ee00405342ff310c3b1fedb35
> [ Adjusted for barebox for some missing commits ]
>
> The comment line for addtree says "skip if -I has no parameter".
>
> What it actually does is "drop if -I has no parameter". For example,
> if you have the compiler flag '-I foo' (a space between), it will be
> converted to 'foo'. This completely changes the meaning.
>
> What we want is, "do nothing" for -I without parameter so that
> '-I foo' is kept as-is.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
Applied this one and the Kconfig update ontop of it. Thanks,
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-06-13 6:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 10:16 Masahiro Yamada
2019-06-13 6:25 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613062523.hz5xckmfyjl4mm4b@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox