From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC] request_sdram_region: print error message
Date: Mon, 17 Jun 2019 14:12:12 +0200 [thread overview]
Message-ID: <20190617121212.noz2xyz2r5g5iwiu@pengutronix.de> (raw)
In-Reply-To: <20190613125848.15994-1-antonynpavlov@gmail.com>
On Thu, Jun 13, 2019 at 03:58:48PM +0300, Antony Pavlov wrote:
> I have found that MIPS memory misconfiguration leads to
> request_sdram_region() errors. But mem_malloc_resource()
> has no error checks for request_sdram_region() result.
> MIPS memory mapping needs additional changes this commit
> is just RFC on request_sdram_region().
>
> Can we embed error message into request_sdram_region()?
In create_vector_table() failure of request_sdram_region() is expected
and not an error, so putting an error message into
request_sdram_region() is not a good idea. What we could do though
is to print an error message based on a "verbose" input flag.
>
> The commid introduce necessary chages but I have no idea
> how to change this part of arch/arm/cpu/mmu.c:
>
> if (!request_sdram_region("ttb", (unsigned long)ttb, SZ_16K))
> /*
> * This can mean that:
> * - the early MMU code has put the ttb into a place
> * which we don't have inside our available memory
> * - Somebody else has occupied the ttb region which means
> * the ttb will get corrupted.
> */
> pr_crit("Critical Error: Can't request SDRAM region for ttb at %p\n",
> ttb);
I think the message should stay like it is.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-06-17 12:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 12:58 Antony Pavlov
2019-06-17 12:12 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617121212.noz2xyz2r5g5iwiu@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox