mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* Raspberry CM3 eMMC Boot
@ 2019-06-17 13:44 Rico Pahlisch
  2019-06-18  7:57 ` Sascha Hauer
  0 siblings, 1 reply; 4+ messages in thread
From: Rico Pahlisch @ 2019-06-17 13:44 UTC (permalink / raw)
  To: barebox

Hello,

I try to boot from the internal eMMC with the raspberry CM3 barebox
build but I dont get a promt.
After changing the code barebox works fine. Does any one else have
problems with the raspberry 3 compute module.

diff --git a/drivers/pinctrl/pinctrl-bcm2835.c
b/drivers/pinctrl/pinctrl-bcm2835.c
index 5fd5740..56daa04 100644
--- a/drivers/pinctrl/pinctrl-bcm2835.c
+++ b/drivers/pinctrl/pinctrl-bcm2835.c
@@ -209,4 +209,4 @@ static int bcm2835_gpio_add(void)
 {
        return platform_driver_register(&bcm2835_gpio_driver);
 }
-coredevice_initcall(bcm2835_gpio_add);
+device_initcall(bcm2835_gpio_add);


Best regards,
Rico

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Raspberry CM3 eMMC Boot
  2019-06-17 13:44 Raspberry CM3 eMMC Boot Rico Pahlisch
@ 2019-06-18  7:57 ` Sascha Hauer
  2019-06-18  8:51   ` Rico Pahlisch
  2019-06-18 12:17   ` Tomaž Šolc
  0 siblings, 2 replies; 4+ messages in thread
From: Sascha Hauer @ 2019-06-18  7:57 UTC (permalink / raw)
  To: Rico Pahlisch; +Cc: barebox

Hi Rico,

On Mon, Jun 17, 2019 at 03:44:17PM +0200, Rico Pahlisch wrote:
> Hello,
> 
> I try to boot from the internal eMMC with the raspberry CM3 barebox
> build but I dont get a promt.
> After changing the code barebox works fine. Does any one else have
> problems with the raspberry 3 compute module.
> 
> diff --git a/drivers/pinctrl/pinctrl-bcm2835.c
> b/drivers/pinctrl/pinctrl-bcm2835.c
> index 5fd5740..56daa04 100644
> --- a/drivers/pinctrl/pinctrl-bcm2835.c
> +++ b/drivers/pinctrl/pinctrl-bcm2835.c
> @@ -209,4 +209,4 @@ static int bcm2835_gpio_add(void)
>  {
>         return platform_driver_register(&bcm2835_gpio_driver);
>  }
> -coredevice_initcall(bcm2835_gpio_add);
> +device_initcall(bcm2835_gpio_add);

I have no idea why this helps. Do you have any logs that explain the
issue?

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Raspberry CM3 eMMC Boot
  2019-06-18  7:57 ` Sascha Hauer
@ 2019-06-18  8:51   ` Rico Pahlisch
  2019-06-18 12:17   ` Tomaž Šolc
  1 sibling, 0 replies; 4+ messages in thread
From: Rico Pahlisch @ 2019-06-18  8:51 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: barebox

This are the logs first without the patch and then with patch.
Only with the patch I get a barebox promt.

Not working logs:
Board: RaspberryPi Compute Module 3
bcm2835-gpio 3f200000.gpio@7e200000.of: probed gpiochip-1 with base 0
bcm2835_mci 3f300000.sdhci@7e300000.of: registered as mci0
<NULL>: Failed to get 'vmmc' regulator.
bcm2835-sdhost 3f202000.mmc@7e202000.of: registered as mci1

Working logs:
Board: RaspberryPi Compute Module 3
bcm2835_mci 3f300000.sdhci@7e300000.of: registered as mci0
<NULL>: Failed to get 'vmmc' regulator.
bcm2835-sdhost 3f202000.mmc@7e202000.of: registered as mci1
mci0: detected MMC card version 5.1
mci0: registered disk0
state: New state registered 'state'
state: Using bucket 0@0x00000000
bcm2835-gpio 3f200000.gpio@7e200000.of: probed gpiochip-1 with base 0
malloc space: 0x0fe7e2e0 -> 0x1fcfc5bf (size 254.5 MiB)
environment load /boot/barebox.env: No such file or directory
Maybe you have to create the partition.

Am Di., 18. Juni 2019 um 09:57 Uhr schrieb Sascha Hauer
<s.hauer@pengutronix.de>:
>
> Hi Rico,
>
> On Mon, Jun 17, 2019 at 03:44:17PM +0200, Rico Pahlisch wrote:
> > Hello,
> >
> > I try to boot from the internal eMMC with the raspberry CM3 barebox
> > build but I dont get a promt.
> > After changing the code barebox works fine. Does any one else have
> > problems with the raspberry 3 compute module.
> >
> > diff --git a/drivers/pinctrl/pinctrl-bcm2835.c
> > b/drivers/pinctrl/pinctrl-bcm2835.c
> > index 5fd5740..56daa04 100644
> > --- a/drivers/pinctrl/pinctrl-bcm2835.c
> > +++ b/drivers/pinctrl/pinctrl-bcm2835.c
> > @@ -209,4 +209,4 @@ static int bcm2835_gpio_add(void)
> >  {
> >         return platform_driver_register(&bcm2835_gpio_driver);
> >  }
> > -coredevice_initcall(bcm2835_gpio_add);
> > +device_initcall(bcm2835_gpio_add);
>
> I have no idea why this helps. Do you have any logs that explain the
> issue?
>
> Sascha
>
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



-- 

Rico Pahlisch
Senior Software Developer

Kiwigrid GmbH

Kleiststraße 10 a – c | 01129 Dresden | Germany

rico.pahlisch@kiwigrid.com | www.kiwigrid.com

Registered Office/ Sitz der Gesellschaft: Dresden
Registered Court/ Registergericht: Amtsgericht Dresden | HRB 30058
Chairman of the Advisory Board/ Beiratsvorsitzender: Hans-Peter Villis
Managing Directors/ Geschäftsführer: Matthias Hertel (Speaker/
Sprecher), Tim Ulbricht

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Raspberry CM3 eMMC Boot
  2019-06-18  7:57 ` Sascha Hauer
  2019-06-18  8:51   ` Rico Pahlisch
@ 2019-06-18 12:17   ` Tomaž Šolc
  1 sibling, 0 replies; 4+ messages in thread
From: Tomaž Šolc @ 2019-06-18 12:17 UTC (permalink / raw)
  To: barebox

On 18. 06. 19 09:57, Sascha Hauer wrote:
> Hi Rico,
> 
> On Mon, Jun 17, 2019 at 03:44:17PM +0200, Rico Pahlisch wrote:
>> -coredevice_initcall(bcm2835_gpio_add);
>> +device_initcall(bcm2835_gpio_add);
> 
> I have no idea why this helps. Do you have any logs that explain the
> issue?

The problem is that gpio alt functions aren't getting setup correctly. 
Rico's patch makes mci init take place before gpio init, which seems to 
work around the problem, but doesn't actually fix the core issue.

The problem is actually my commit 9eed45c7, which was made before sdhost 
driver was functional in barebox. It enables sdhci in devicetree, but 
doesn't disable sdhost.

This makes both sdhost and sdhci nodes active. If 
CONFIG_MCI_BCM283X_SDHOST is enabled (which is in rpi_defconfig since 
b093468c), both drivers try to fetch the alt function for the same set 
of GPIOs, which obviously doesn't work.

So basically what I think needs to be done is disable sdhci on Compute 
Module now that sdhost works. Same thing as was done for R.Pi 3 by Lucas 
in 9036d1db.

Rico, can you check if the patch below works for you?

Best regards
Tomaž


diff --git a/arch/arm/dts/bcm2837-rpi-cm3.dts 
b/arch/arm/dts/bcm2837-rpi-cm3.dts
index cfbffe175..01c1f9a67 100644
--- a/arch/arm/dts/bcm2837-rpi-cm3.dts
+++ b/arch/arm/dts/bcm2837-rpi-cm3.dts
@@ -9,10 +9,3 @@
                 reg = <0x0 0x0>;
         };
  };
-
-&sdhci {
-       pinctrl-0 = <&emmc_gpio48>;
-       no-sd;
-       non-removable;
-       status = "okay";
-};

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-06-18 12:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-17 13:44 Raspberry CM3 eMMC Boot Rico Pahlisch
2019-06-18  7:57 ` Sascha Hauer
2019-06-18  8:51   ` Rico Pahlisch
2019-06-18 12:17   ` Tomaž Šolc

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox