* memcmp command is broken
@ 2019-07-04 16:56 Peter Mamonov
2019-07-09 5:15 ` Andrey Smirnov
0 siblings, 1 reply; 2+ messages in thread
From: Peter Mamonov @ 2019-07-04 16:56 UTC (permalink / raw)
To: andrew.smirnov, barebox
Hi, Andrey,
Current `memcmp` command implementation is broken and fails with the error
message "read: Bad file number" when calls `read_full(destfd, ...)`. Guess this
is because `memcpy_parse_options()` opens `destfd` with `O_WRONLY` flag. Anyway
reverting "ddf4cca339 commands: Introduce memcpy_parse_options()" fixes the
problem.
Regards,
Peter
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: memcmp command is broken
2019-07-04 16:56 memcmp command is broken Peter Mamonov
@ 2019-07-09 5:15 ` Andrey Smirnov
0 siblings, 0 replies; 2+ messages in thread
From: Andrey Smirnov @ 2019-07-09 5:15 UTC (permalink / raw)
To: Peter Mamonov; +Cc: Barebox List
On Thu, Jul 4, 2019 at 9:56 AM Peter Mamonov <pmamonov@gmail.com> wrote:
>
> Hi, Andrey,
>
> Current `memcmp` command implementation is broken and fails with the error
> message "read: Bad file number" when calls `read_full(destfd, ...)`. Guess this
> is because `memcpy_parse_options()` opens `destfd` with `O_WRONLY` flag. Anyway
> reverting "ddf4cca339 commands: Introduce memcpy_parse_options()" fixes the
> problem.
>
Yeah, you are right, sorry about that. I'll submit a fix shortly.
Thanks,
Andrey Smirnov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-09 5:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-04 16:56 memcmp command is broken Peter Mamonov
2019-07-09 5:15 ` Andrey Smirnov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox