mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org, Peter Mamonov <pmamonov@gmail.com>
Subject: Re: [PATCH] lib: Add missing arguments to memcpy_parse_options()
Date: Tue, 9 Jul 2019 11:41:18 +0200	[thread overview]
Message-ID: <20190709094118.ye6jaujeeec7lc3d@pengutronix.de> (raw)
In-Reply-To: <20190709072253.22062-1-andrew.smirnov@gmail.com>

On Tue, Jul 09, 2019 at 12:22:53AM -0700, Andrey Smirnov wrote:
> Memcpy use-case differs from that of memcmp in default access type and
> destination file mode. This was missed in original commit that
> introduced memcpy_parse_options(). Add said parameters to
> memcpy_parse_options(), so the can be correctly specified depending on
> the use-case.
> 
> Fixes: ddf4cca339 ("commands: Introduce memcpy_parse_options()")
> Reported-by: Peter Mamonov <pmamonov@gmail.com>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  commands/memcmp.c | 3 ++-
>  commands/memcpy.c | 3 ++-
>  include/common.h  | 3 ++-
>  lib/misc.c        | 7 ++++---
>  4 files changed, 10 insertions(+), 6 deletions(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2019-07-09  9:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-09  7:22 Andrey Smirnov
2019-07-09  9:41 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190709094118.ye6jaujeeec7lc3d@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=andrew.smirnov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=pmamonov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox