mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] watchdog: stm32_iwdg: remove left-over comment
@ 2019-07-10 19:00 Ahmad Fatoum
  2019-07-11  6:43 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2019-07-10 19:00 UTC (permalink / raw)
  To: barebox

The reset reason part of the code is based on the i.MX6's and duplicated
a comment from there, which isn't applicable to the STM32. Delete it.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/watchdog/stm32_iwdg.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/watchdog/stm32_iwdg.c b/drivers/watchdog/stm32_iwdg.c
index 34912ae00eea..7c2dc077af5b 100644
--- a/drivers/watchdog/stm32_iwdg.c
+++ b/drivers/watchdog/stm32_iwdg.c
@@ -170,11 +170,6 @@ static int stm32_set_reset_reason(struct regmap *rcc)
 	int ret;
 	int i, instance = 0;
 
-	/*
-	 * SRSR register captures ALL reset event that occured since
-	 * POR, so we need to clear it to make sure we only caputre
-	 * the latest one.
-	 */
 	ret = regmap_read(rcc, RCC_MP_RSTSCLRR, &reg);
 	if (ret)
 		return ret;
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] watchdog: stm32_iwdg: remove left-over comment
  2019-07-10 19:00 [PATCH] watchdog: stm32_iwdg: remove left-over comment Ahmad Fatoum
@ 2019-07-11  6:43 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2019-07-11  6:43 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox

On Wed, Jul 10, 2019 at 09:00:11PM +0200, Ahmad Fatoum wrote:
> The reset reason part of the code is based on the i.MX6's and duplicated
> a comment from there, which isn't applicable to the STM32. Delete it.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  drivers/watchdog/stm32_iwdg.c | 5 -----
>  1 file changed, 5 deletions(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-07-11  6:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-10 19:00 [PATCH] watchdog: stm32_iwdg: remove left-over comment Ahmad Fatoum
2019-07-11  6:43 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox