mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Subject: [PATCH] fixup! reset: add reset controller driver for STM32 RCC
Date: Wed, 10 Jul 2019 23:28:36 +0200	[thread overview]
Message-ID: <20190710212836.887-1-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20190710201112.9086-4-a.fatoum@pengutronix.de>

This fixes some unfortunate last-moment refactoring.
With this change, the reset works correctly now.
---
 drivers/reset/reset-stm32.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/reset/reset-stm32.c b/drivers/reset/reset-stm32.c
index ff66fe310e1a..5689dfd4888a 100644
--- a/drivers/reset/reset-stm32.c
+++ b/drivers/reset/reset-stm32.c
@@ -26,8 +26,8 @@ static struct stm32_reset *to_stm32_reset(struct reset_controller_dev *rcdev)
 
 static void stm32mp_reset(void __iomem *reg, unsigned offset, bool assert)
 {
-	if (assert)
-		offset += RCC_CL;
+	if (!assert)
+		reg += RCC_CL;
 
 	writel(BIT(offset), reg);
 }
-- 
2.20.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2019-07-10 21:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-10 20:11 [PATCH 1/7] gpio: allow for arch-specific ARCH_NR_GPIOS > 256 Ahmad Fatoum
2019-07-10 20:11 ` [PATCH 2/7] ARM: stm32mp: set CONFIG_ARCH_NR_GPIO = (26 * 16) Ahmad Fatoum
2019-07-10 20:11 ` [PATCH 3/7] ARM: dts: stm32mp157c: correct gpioz id Ahmad Fatoum
2019-07-10 20:11 ` [PATCH 4/7] reset: add reset controller driver for STM32 RCC Ahmad Fatoum
2019-07-10 21:28   ` Ahmad Fatoum [this message]
2019-07-10 20:11 ` [PATCH 5/7] i2c: add stm32f7 I2C adapter driver Ahmad Fatoum
2019-07-12  5:09   ` Sascha Hauer
2019-07-10 20:11 ` [PATCH 6/7] mfd: add support for STPMIC1 Ahmad Fatoum
2019-07-10 20:11 ` [PATCH 7/7] watchdog: add support for STPMIC1 integrated watchdog Ahmad Fatoum
2019-07-15  6:42 ` [PATCH 1/7] gpio: allow for arch-specific ARCH_NR_GPIOS > 256 Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190710212836.887-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox