From: Sascha Hauer <s.hauer@pengutronix.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 1/3] OF: gpio: Add special quirk to parse regulator flags
Date: Wed, 17 Jul 2019 11:25:14 +0200 [thread overview]
Message-ID: <20190717092514.crbcl5vpymanvf3c@pengutronix.de> (raw)
In-Reply-To: <20190716103557.17446-1-o.rempel@pengutronix.de>
On Tue, Jul 16, 2019 at 12:35:55PM +0200, Oleksij Rempel wrote:
> To make fec work with devicetree on imx28-evk, partially port following
> kernel patch:
>
> |commit a603a2b8d86ee93ee2107da8ca75fd854fd4ff32
> |Author: Linus Walleij <linus.walleij@linaro.org>
> |Date: Sat Dec 30 16:26:36 2017 +0100
> |
> | gpio: of: Add special quirk to parse regulator flags
> |
> | While most GPIOs are indicated to be active low or open drain using
> | their twocell flags, we have legacy regulator bindings to take into
> | account.
> |
> | Add a quirk respecting the special boolean active-high and open
> | drain flags when parsing regulator nodes for GPIOs.
> |
> | This makes it possible to get rid of duplicated inversion semantics
> | handling in the regulator core and any regulator drivers parsing
> | and handling this separately.
> |
> | Unfortunately the old regulator inversion semantics are specified
> | such that the presence or absence of "enable-active-high" solely
> | controls the semantics, so we cannot deprecate this in favor
> | of the phandle-provided inversion flag, instead any such phandle
> | inversion flag provided in the second cell of a GPIO handle must be
> | actively ignored, so we print a warning to contain the situation
> | and make things easy for the users.
> |
> | Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> drivers/of/of_gpio.c | 35 ++++++++++++++++++++++++++++++++++-
> 1 file changed, 34 insertions(+), 1 deletion(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-07-17 9:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 10:35 Oleksij Rempel
2019-07-16 10:35 ` [PATCH v2 2/3] net: fec_imx: add regulator support Oleksij Rempel
2019-07-16 10:35 ` [PATCH v2 3/3] arm: port imx28-evk to devicetree Oleksij Rempel
2019-07-17 9:25 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717092514.crbcl5vpymanvf3c@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox