From: Sascha Hauer <s.hauer@pengutronix.de>
To: Bastian Krause <bst@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/3] common: machine_id: introduce machine id generation and pass id on
Date: Wed, 17 Jul 2019 12:31:49 +0200 [thread overview]
Message-ID: <20190717103149.jub6iz2lulyy5f32@pengutronix.de> (raw)
In-Reply-To: <333c80d8-ae65-1ed4-9c18-ab9bb31716a1@pengutronix.de>
On Wed, Jul 17, 2019 at 11:58:59AM +0200, Bastian Krause wrote:
>
> >> + struct digest *digest = NULL;
> >> + unsigned char machine_id[SHA1_DIGEST_SIZE];
> >> + char *hex_id;
> >> + int ret = 0;
> >> +
> >> + if (!__machine_id_hashable) {
> >> + pr_warn("No hashable set, will not pass id to kernel\n");
> >
> > I don't think this is worth a warning. With this series this will be
> > issued for example on all non i.MX6 boards enabled in imx_v7_defconfig.
>
> If I enable CONFIG_MACHINE_ID I'd expect the machine id being passed to
> the kernel. This is not the case for these boards. Isn't that somewhat
> surprising?
With that argument we would get a lot of warnings in a imx_v7_defconfig.
A lot of features end up unused on different boards.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-07-17 10:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 10:58 [PATCH 1/3] digest.h: needs errno definitions Bastian Krause
2019-07-16 10:58 ` [PATCH 2/3] common: machine_id: introduce machine id generation and pass id on Bastian Krause
2019-07-17 9:48 ` Sascha Hauer
2019-07-17 9:58 ` Bastian Krause
2019-07-17 10:31 ` Sascha Hauer [this message]
2019-07-17 10:34 ` Bastian Krause
2019-07-17 9:53 ` Ahmad Fatoum
2019-07-17 10:02 ` Roland Hieber
2019-07-17 10:31 ` Ahmad Fatoum
2019-07-17 14:02 ` Bastian Krause
2019-07-17 14:18 ` Sascha Hauer
2019-07-16 10:58 ` [PATCH 3/3] nvmem: ocotp: set unique id as machine-id hashable Bastian Krause
2019-07-17 9:50 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717103149.jub6iz2lulyy5f32@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=bst@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox