From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH v3 0/6] clk: imx6: work around LDB hang caused by ERR009219
Date: Wed, 17 Jul 2019 19:05:58 +0200 [thread overview]
Message-ID: <20190717170604.23732-1-a.fatoum@pengutronix.de> (raw)
Short version:
barebox always reparents the ldb_di[01] clocks to pll5_video_div.
Due to a hardware erratum, this can trigger a glitch that causes
LDB lock up.
Thus:
1) remove the automatic reparenting, like the kernel now does and
mark the affected clocks read only, so assigned-clock-parents
can't affect them
2) parse assigned-clock-parents in the clk-imx6 code as well, but
there use a convoluted non-glitchy work around to apply them
Long version available alongside v1 here:
https://www.spinics.net/lists/u-boot-v2/msg37658.html
and in the commit messages of the patches.
v2 is available here:
https://www.spinics.net/lists/u-boot-v2/msg37970.html
Changes since v2:
- reordered commits to avoid intermittent breakage, final
diff unaffected
- prepended a commit fixing premature use of cpu_is_mx6
- fixed brace placement of cpu_(mx6_)?has_err009219
- changed commits to use cpu_mx6_is_mx6*, all suggested by Andrey
- updated commit messages, collected Andrey's Tested-By and
Philipp's Reviewed-By
Changes since v1:
- reordered/squashed commits after discussion with Sascha and Phillip
- removed superfluous comment
- add MUX_READ_ONLY at the correct place in the MUX_READ_ONLY arguments
Except for the last two, the total diff, is exactly the same
as v1's.
Ahmad Fatoum (3):
clk: imx6: fix use of cpu_is_mx6* before they are initialized
clk: imx6: remove quirky clk_set_parent(LDB_diN_sel, pll5_video_div)
clk: imx6: define an enum for ldb mux inputs
Fabio Estevam (1):
clk: imx6: Fix procedure to switch the parent of LDB_DI_CLK
Philipp Zabel (2):
clk: imx6: Mask mmdc_ch1 handshake for periph2_sel and
mmdc_ch1_axi_podf
clk: imx6: Make the LDB_DI0 and LDB_DI1 clocks read-only
drivers/clk/imx/clk-imx6.c | 329 ++++++++++++++++++++++++++++++++++---
drivers/clk/imx/clk.h | 8 +
2 files changed, 317 insertions(+), 20 deletions(-)
--
2.20.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2019-07-17 17:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 17:05 Ahmad Fatoum [this message]
2019-07-17 17:05 ` [PATCH v3 1/6] clk: imx6: fix use of cpu_is_mx6* before they are initialized Ahmad Fatoum
2019-07-17 17:10 ` Ahmad Fatoum
2019-07-18 15:51 ` Ahmad Fatoum
2019-07-17 17:06 ` [PATCH v3 2/6] clk: imx6: Mask mmdc_ch1 handshake for periph2_sel and mmdc_ch1_axi_podf Ahmad Fatoum
2019-07-17 17:06 ` [PATCH v3 3/6] clk: imx6: remove quirky clk_set_parent(LDB_diN_sel, pll5_video_div) Ahmad Fatoum
2019-07-17 17:06 ` [PATCH v3 4/6] clk: imx6: Make the LDB_DI0 and LDB_DI1 clocks read-only Ahmad Fatoum
2019-07-18 8:19 ` Roland Hieber
2019-07-18 8:25 ` Ahmad Fatoum
2019-07-18 8:33 ` Roland Hieber
2019-08-05 10:22 ` Sascha Hauer
2019-07-17 17:06 ` [PATCH v3 5/6] clk: imx6: Fix procedure to switch the parent of LDB_DI_CLK Ahmad Fatoum
2019-09-10 13:15 ` Sascha Hauer
2019-09-10 14:07 ` Ahmad Fatoum
2019-07-17 17:06 ` [PATCH v3 6/6] clk: imx6: define an enum for ldb mux inputs Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717170604.23732-1-a.fatoum@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox