From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] UBI: silence erroneous GCC warning about uninitialized read
Date: Thu, 18 Jul 2019 08:53:00 +0200 [thread overview]
Message-ID: <20190718065300.fswsh5t5vxaiyb6e@pengutronix.de> (raw)
In-Reply-To: <20190715145522.9589-1-a.fatoum@pengutronix.de>
On Mon, Jul 15, 2019 at 04:55:22PM +0200, Ahmad Fatoum wrote:
> GCC reports following use of an uninitialized variable:
>
> ./drivers/mtd/ubi/eba.c: In function 'try_write_vid_and_data':
> ./drivers/mtd/ubi/eba.c:904:9: warning:
> 'opnum' may be used uninitialized in this function [-Wmaybe-uninitialized]
> err = ubi_wl_put_peb(ubi, vol_id, lnum, opnum, 0);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> This is incorrect, because it's only called when err == 0 and opnum
> is always initialized if err == 0. Silence the warning by initializing
> a variable.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> drivers/mtd/ubi/eba.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-07-18 6:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 14:55 Ahmad Fatoum
2019-07-18 6:53 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718065300.fswsh5t5vxaiyb6e@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox