From: Sascha Hauer <s.hauer@pengutronix.de>
To: Bastian Krause <bst@pengutronix.de>
Cc: barebox@lists.infradead.org,
Steffen Trumtrar <s.trumtrar@pengutronix.de>
Subject: Re: [PATCH] mtd: spi-nor: fix page offset/remains calculation in spi_nor_write
Date: Mon, 5 Aug 2019 11:34:40 +0200 [thread overview]
Message-ID: <20190805093440.kckx6nbmzogjdi6x@pengutronix.de> (raw)
In-Reply-To: <20190801091950.14606-1-bst@pengutronix.de>
On Thu, Aug 01, 2019 at 11:19:50AM +0200, Bastian Krause wrote:
> nor->write() simply adds the number of written bytes to the pointer
> given. Thus retval is incremented in each loop cycle for each
> spi_nor_write() call without ever resetting it. This leads to wrong page
> offset/remains calculations and an incorrect number of bytes written to
> retlen.
>
> This becomes apparant only if the calling function actually compares len
> and retlen (e.g. mtd_peb_write() ). Otherwise wrong data is written:
>
> $ memcpy -s /dev/prng -d prng_data 0 0 10k
> $ erase /dev/mtd0.mypart
> $ cp prng_data /dev/mtd0.mypart
> $ memcmp -s prng_data -d /dev/mtd0.mypart 0 0
>
> memcmp returned "files differ" before, with this patch it returns "OK".
>
> Fixes: c8516869c4 ("spi: Extend the core to ease integration of SPI memory controllers")
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> ---
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2019-08-05 9:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 9:19 Bastian Krause
2019-08-01 13:16 ` Bastian Krause
2019-08-05 9:34 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805093440.kckx6nbmzogjdi6x@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=bst@pengutronix.de \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox